Code cleanup pass

Author: SpicyPete

frontend/src/components/pages/rp-connect/onboarding/add-topic-step.tsx

@@ -366,7 +366,7 @@ export const AddTopicStep = forwardRef<BaseStepRef<AddTopicFormData>, AddTopicSt
                   )}
                 />
 
-                {watchedTopicName !== '' && watchedTopicName.length > 0 && (
+                {watchedTopicName && (
                   <Button disabled={isPending} onClick={handleClearTopicName} size="icon" variant="ghost">
                     <XIcon size={16} />
                   </Button>

frontend/src/components/pages/rp-connect/onboarding/add-user-step.tsx

@@ -510,7 +510,7 @@ export const AddUserStep = forwardRef<UserStepRef, AddUserStepProps & MotionProp
                           )}
                         />
 
-                        {watchedUsername !== '' && watchedUsername.length > 0 && (
+                        {watchedUsername && (
                           <Button disabled={isPending} onClick={handleClearUsername} size="icon" variant="ghost">
                             <XIcon size={16} />
                           </Button>
@@ -762,7 +762,7 @@ export const AddUserStep = forwardRef<UserStepRef, AddUserStepProps & MotionProp
                             )}
                           />
 
-                          {watchedConsumerGroup !== '' && watchedConsumerGroup && watchedConsumerGroup.length > 0 && (
+                          {watchedConsumerGroup && (
                             <Button disabled={isPending} onClick={handleClearConsumerGroup} size="icon" variant="ghost">
                               <XIcon size={16} />
                             </Button>

frontend/src/components/pages/rp-connect/pipeline/index.tsx

@@ -752,7 +752,6 @@ export default function PipelinePage() {
   const [slashTipVisible, setSlashTipVisible] = useState(isSlashMenuEnabled && mode !== 'view');
   const [isTemplateDialogOpen, setIsTemplateDialogOpen] = useState(false);
   const isTemplateGalleryEnabled = isFeatureFlagEnabled('enableConnectTemplateGallery');
-  const lintPanelRef = useRef<ImperativePanelHandle>(null);
 
   const form = useForm<PipelineFormValues>({
     resolver: zodResolver(pipelineFormSchema) as Resolver<PipelineFormValues>,

frontend/src/components/pages/rp-connect/template-gallery/template-deploy.ts

@@ -14,6 +14,8 @@ import { getSecretSyntax } from '../types/constants';
 
 export type SlotValues = Record<string, string>;
 
+const isBlank = (v: string | undefined): boolean => !v?.trim();
+
 // Secret slots become `${secrets.NAME}`; everything else inlines as-is.
 const substituteToken = (slot: TemplateSlot, raw: string): string => {
   if (slot.kind === 'secret') {
@@ -51,7 +53,7 @@ export const stitchTemplateYaml = ({
   const kept: string[] = [];
   for (const line of template.baseYaml.split('\n')) {
     const refs = referencedSlotIdsIn(line);
-    if (refs.length > 0 && refs.some((id) => !values[id]?.trim())) {
+    if (refs.length > 0 && refs.some((id) => isBlank(values[id]))) {
       continue;
     }
     kept.push(
@@ -72,7 +74,7 @@ export const stitchTemplateYaml = ({
 
 export const findMissingRequiredSlot = (template: PipelineTemplate, values: SlotValues): string | undefined => {
   for (const slot of template.slots) {
-    if (slot.required && !values[slot.id]?.trim()) {
+    if (slot.required && isBlank(values[slot.id])) {
       return slot.id;
     }
   }

frontend/src/components/pages/rp-connect/template-gallery/template-form-panel.tsx

@@ -85,15 +85,7 @@ const defaultValuesFor = (template: PipelineTemplate, slots: TemplateSlot[]): Re
     [PIPELINE_NAME_FIELD]: template.defaultPipelineName,
   };
   for (const slot of slots) {
-    if (slot.kind === 'string' && slot.default) {
-      defaults[slot.id] = slot.default;
-    } else if (slot.kind === 'topic' && slot.default) {
-      defaults[slot.id] = slot.default;
-    } else if (slot.kind === 'select' && slot.default) {
-      defaults[slot.id] = slot.default;
-    } else {
-      defaults[slot.id] = '';
-    }
+    defaults[slot.id] = slot.kind === 'secret' ? '' : (slot.default ?? '');
   }
   return defaults;
 };

frontend/src/components/pages/rp-connect/template-gallery/template-schema.ts

@@ -51,15 +51,9 @@ export function applySchemaToSlots(template: PipelineTemplate, componentList?: C
       required: slot.required ?? checkRequired(field as unknown as RawFieldSpec),
     };
 
-    // Default only applies to kinds that expose one.
-    if (
-      (merged.kind === 'string' || merged.kind === 'topic' || merged.kind === 'select') &&
-      !merged.default &&
-      field.defaultValue
-    ) {
+    if (merged.kind !== 'secret' && !merged.default && field.defaultValue) {
       return { ...merged, default: field.defaultValue };
     }
-
     return merged;
   });
 }