Commit 94449f4
authored
fix(topics): hide Infinite button for capped configs + fix Custom SELECT width (UX-1235) (#2418)
* fix(topics): hide Infinite button for capped config keys (UX-1222)
The topic config editor showed an "Infinite" button for every config whose
frontendFormat was BYTE_SIZE or DURATION. For configs that the broker hard-caps
(e.g. max.message.bytes, segment.bytes), clicking it submitted -1, which the
broker reinterpreted as 4294967295 and rejected with INVALID_CONFIG.
Add an opt-out field `noInfiniteValue` to the config extension schema.
Configs that do not accept an infinite sentinel declare it in JSON, and the
frontend hides the Infinite button for them. BYTE_SIZE and DURATION configs
continue to show the button by default.
Apply the opt-out to max.message.bytes and segment.bytes.
* fix(topics): force min width on Custom SELECT dropdown (UX-1235)
chakra-react-select's container has an intrinsic maxWidth: fit-content,
so even with a minW on the wrapping Box the SingleSelect collapses to
the width of its current value. For message.timestamp.type with no
initial value the whole control rendered at ~69px and option labels
were truncated to "Creat" / "LogA".
Override via chakraStyles on the SELECT case to set container
minWidth: 240px directly. Keeps the Custom Box layout untouched for
BYTE_SIZE / DURATION controls.1 parent d65f80d commit 94449f4
4 files changed
Lines changed: 16 additions & 3 deletions
File tree
- backend/pkg
- console
- embed/kafka
- frontend/src
- components/pages/topics
- state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
55 | 61 | | |
56 | 62 | | |
57 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
105 | | - | |
| 106 | + | |
| 107 | + | |
106 | 108 | | |
107 | 109 | | |
108 | 110 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
83 | 86 | | |
84 | 87 | | |
85 | 88 | | |
| |||
439 | 442 | | |
440 | 443 | | |
441 | 444 | | |
| 445 | + | |
442 | 446 | | |
443 | 447 | | |
444 | 448 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
| 280 | + | |
280 | 281 | | |
281 | 282 | | |
282 | 283 | | |
| |||
0 commit comments