Skip to content

Commit c9246f8

Browse files
committed
fix: address code review comments
- Run Biome formatter to fix import ordering and code style - Change pageSize from 1000 to 100 for gateway queries - Rename useLegacyApiKeyMode to isLegacyApiKeyMode (non-hook variable) - Clarify proxy configuration supports both Console backend and AI Gateway - Update useEffect dependencies for exhaustive deps check
1 parent 7d32912 commit c9246f8

2 files changed

Lines changed: 17 additions & 17 deletions

File tree

frontend/src/components/pages/agents/create/ai-agent-create-page.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,24 +75,24 @@ export const AIAgentCreatePage = () => {
7575
});
7676

7777
// Feature flag: when true, use legacy API key mode (hardcoded providers)
78-
const useLegacyApiKeyMode = isFeatureFlagEnabled('enableApiKeyConfigurationAgent');
78+
const isLegacyApiKeyMode = isFeatureFlagEnabled('enableApiKeyConfigurationAgent');
7979

8080
// Gateway detection and list query (using v1 API from ai-gateway module)
8181
// Only fetch when NOT in legacy mode
8282
const { data: gatewaysData, isLoading: isLoadingGateways } = useListGatewaysQuery(
83-
{ pageSize: 1000 }, // Get all gateways (max 1000)
84-
{ enabled: !useLegacyApiKeyMode }
83+
{ pageSize: 100 },
84+
{ enabled: !isLegacyApiKeyMode }
8585
);
8686

8787
const hasGatewayDeployed = useMemo(() => {
88-
if (useLegacyApiKeyMode || isLoadingGateways) {
88+
if (isLegacyApiKeyMode || isLoadingGateways) {
8989
return false;
9090
}
9191
return Boolean(gatewaysData?.gateways && gatewaysData.gateways.length > 0);
92-
}, [useLegacyApiKeyMode, gatewaysData, isLoadingGateways]);
92+
}, [isLegacyApiKeyMode, gatewaysData, isLoadingGateways]);
9393

9494
const availableGateways = useMemo(() => {
95-
if (useLegacyApiKeyMode || !gatewaysData?.gateways) {
95+
if (isLegacyApiKeyMode || !gatewaysData?.gateways) {
9696
return [];
9797
}
9898
return gatewaysData.gateways.map((gw) => {
@@ -104,7 +104,7 @@ export const AIAgentCreatePage = () => {
104104
description: gw.description,
105105
};
106106
});
107-
}, [useLegacyApiKeyMode, gatewaysData]);
107+
}, [isLegacyApiKeyMode, gatewaysData]);
108108

109109
// Ref to ServiceAccountSelector to call createServiceAccount
110110
const serviceAccountSelectorRef = useRef<ServiceAccountSelectorRef>(null);
@@ -143,10 +143,10 @@ export const AIAgentCreatePage = () => {
143143

144144
// Auto-select first gateway when gateways are available (only if not in legacy mode)
145145
useEffect(() => {
146-
if (!useLegacyApiKeyMode && availableGateways.length > 0 && !form.getValues('gatewayId')) {
146+
if (!isLegacyApiKeyMode && availableGateways.length > 0 && !form.getValues('gatewayId')) {
147147
form.setValue('gatewayId', availableGateways[0].id);
148148
}
149-
}, [useLegacyApiKeyMode, availableGateways.length, form]);
149+
}, [isLegacyApiKeyMode, availableGateways.length, form]);
150150

151151
const {
152152
fields: tagFields,

frontend/src/react-query/api/ai-gateway.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ import {
99
ListGatewaysRequestSchema,
1010
type ListGatewaysResponse,
1111
} from 'protogen/redpanda/api/aigateway/v1/gateway_pb';
12+
import { listGateways } from 'protogen/redpanda/api/aigateway/v1/gateway-GatewayService_connectquery';
1213
import {
1314
type ListModelProvidersRequest,
1415
ListModelProvidersRequestSchema,
1516
type ListModelProvidersResponse,
1617
} from 'protogen/redpanda/api/aigateway/v1/model_providers_pb';
18+
import { listModelProviders } from 'protogen/redpanda/api/aigateway/v1/model_providers-ModelProvidersService_connectquery';
1719
import {
1820
type ListModelsRequest,
1921
ListModelsRequestSchema,
2022
type ListModelsResponse,
2123
} from 'protogen/redpanda/api/aigateway/v1/models_pb';
22-
import { listGateways } from 'protogen/redpanda/api/aigateway/v1/gateway-GatewayService_connectquery';
23-
import { listModelProviders } from 'protogen/redpanda/api/aigateway/v1/model_providers-ModelProvidersService_connectquery';
2424
import { listModels } from 'protogen/redpanda/api/aigateway/v1/models-ModelsService_connectquery';
2525
import type { MessageInit, QueryOptions } from 'react-query/react-query.utils';
2626

@@ -46,8 +46,8 @@ export const useListGatewaysQuery = (
4646
return useQuery(listGateways, listGatewaysRequest, {
4747
enabled: options?.enabled,
4848
transport,
49-
staleTime: 60000, // 1 minute - prevent excessive refetching
50-
gcTime: 300000, // 5 minutes cache
49+
staleTime: 60_000, // 1 minute - prevent excessive refetching
50+
gcTime: 300_000, // 5 minutes cache
5151
refetchOnWindowFocus: false,
5252
refetchOnMount: false,
5353
refetchOnReconnect: false,
@@ -73,8 +73,8 @@ export const useListModelProvidersQuery = (
7373
return useQuery(listModelProviders, listModelProvidersRequest, {
7474
enabled: options?.enabled,
7575
transport,
76-
staleTime: 60000, // 1 minute - prevent excessive refetching
77-
gcTime: 300000, // 5 minutes cache
76+
staleTime: 60_000, // 1 minute - prevent excessive refetching
77+
gcTime: 300_000, // 5 minutes cache
7878
refetchOnWindowFocus: false,
7979
refetchOnMount: false,
8080
refetchOnReconnect: false,
@@ -105,8 +105,8 @@ export const useListModelsQuery = (
105105
return useQuery(listModels, listModelsRequest, {
106106
enabled: options?.enabled,
107107
transport,
108-
staleTime: 60000, // 1 minute - prevent excessive refetching
109-
gcTime: 300000, // 5 minutes cache
108+
staleTime: 60_000, // 1 minute - prevent excessive refetching
109+
gcTime: 300_000, // 5 minutes cache
110110
refetchOnWindowFocus: false,
111111
refetchOnMount: false,
112112
refetchOnReconnect: false,

0 commit comments

Comments
 (0)