fix(frontend): construct protobuf messages with create(Schema) (#2503)

* fix(frontend): construct protobuf messages with create(Schema)

Replace hand-built object literals carrying hardcoded $typeName strings in
transcript-list-page (AttributeFilter / ListTracesRequest_Filter) and acl-model
(CreateACLRequest) with the protobuf-es v2 create(Schema, ...) API, so a proto
rename or package bump can't silently desync the runtime message from its
registered schema (audit DATA-01).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(frontend): drop redundant proto-default fields in buildApiFilter

Address @claude review nit: create(AttributeFilterSchema) supplies proto
defaults, so the explicit value:'' on the IN filter and values:[] on the
EQUALS/NOT_EQUALS filters are redundant. Keep the IN filter's real
values:['chat','text_completion']. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: malinskibeniamin

frontend/src/components/pages/security/shared/acl-model.tsx

@@ -1,10 +1,12 @@
+import { create } from '@bufbuild/protobuf';
 import type { ConnectError } from '@connectrpc/connect';
 import {
   ACL_Operation,
   ACL_PermissionType,
   ACL_ResourcePatternType,
   ACL_ResourceType,
   type CreateACLRequest,
+  CreateACLRequestSchema,
   type ListACLsResponse,
 } from 'protogen/redpanda/api/dataplane/v1/acl_pb';
 import type { ReactNode } from 'react';
@@ -522,45 +524,48 @@ export function getIdFromCreateACLRequest(request: CreateACLRequest): string {
 // Convert rules to CreateACLRequest array for API calls
 export function convertRulesToCreateACLRequests(rules: Rule[], principal: string, host: string): CreateACLRequest[] {
   return rules.reduce((acc, r) => {
-    const baseRule: Pick<CreateACLRequest, 'resourcePatternType' | '$typeName' | 'resourceName'> = {
+    const baseRule = {
       resourcePatternType:
         r.selectorType === 'any' ? ACL_ResourcePatternType.LITERAL : getGRPCResourcePatternType(r.selectorType),
-      $typeName: 'redpanda.api.dataplane.v1.CreateACLRequest',
       resourceName: getResourceNameValue(r),
     };
     if (r.mode === ModeAllowAll) {
-      const a: CreateACLRequest = {
-        ...baseRule,
-        host,
-        principal,
-        resourceType: getGRPCResourceType(r.resourceType),
-        operation: ACL_Operation.ALL,
-        permissionType: ACL_PermissionType.ALLOW,
-      };
-      acc.push(a);
+      acc.push(
+        create(CreateACLRequestSchema, {
+          ...baseRule,
+          host,
+          principal,
+          resourceType: getGRPCResourceType(r.resourceType),
+          operation: ACL_Operation.ALL,
+          permissionType: ACL_PermissionType.ALLOW,
+        })
+      );
     }
     if (r.mode === ModeDenyAll) {
-      const a: CreateACLRequest = {
-        ...baseRule,
-        host,
-        principal,
-        resourceType: getGRPCResourceType(r.resourceType),
-        operation: ACL_Operation.ALL,
-        permissionType: ACL_PermissionType.DENY,
-      };
-      acc.push(a);
+      acc.push(
+        create(CreateACLRequestSchema, {
+          ...baseRule,
+          host,
+          principal,
+          resourceType: getGRPCResourceType(r.resourceType),
+          operation: ACL_Operation.ALL,
+          permissionType: ACL_PermissionType.DENY,
+        })
+      );
     }
     if (r.mode === ModeCustom) {
       const customResults = Object.entries(r.operations).reduce((operations, [op, opValue]) => {
         if (opValue !== OperationTypeNotSet) {
-          operations.push({
-            ...baseRule,
-            host,
-            principal,
-            resourceType: getGRPCResourceType(r.resourceType),
-            operation: getGRPCOperationType(op),
-            permissionType: getGRPCPermissionType(opValue),
-          });
+          operations.push(
+            create(CreateACLRequestSchema, {
+              ...baseRule,
+              host,
+              principal,
+              resourceType: getGRPCResourceType(r.resourceType),
+              operation: getGRPCOperationType(op),
+              permissionType: getGRPCPermissionType(opValue),
+            })
+          );
         }
         return operations;
       }, [] as CreateACLRequest[]);

frontend/src/components/pages/transcripts/transcript-list-page.tsx

@@ -9,6 +9,7 @@
  * by the Apache License, Version 2.0
  */
 
+import { create } from '@bufbuild/protobuf';
 import { timestampFromMs } from '@bufbuild/protobuf/wkt';
 import type { ColumnFiltersState } from '@tanstack/react-table';
 import { Button } from 'components/redpanda-ui/components/button';
@@ -17,8 +18,10 @@ import { Heading, Link, Text } from 'components/redpanda-ui/components/typograph
 import { parseAsArrayOf, parseAsBoolean, parseAsString, useQueryStates } from 'nuqs';
 import {
   type AttributeFilter,
+  AttributeFilterSchema,
   AttributeOperator,
   type ListTracesRequest_Filter,
+  ListTracesRequest_FilterSchema,
   type TraceSummary,
 } from 'protogen/redpanda/api/dataplane/v1alpha3/tracing_pb';
 import type { FC } from 'react';
@@ -214,50 +217,49 @@ const buildApiFilter = ({
 
   // LLM filter → attribute filter with IN operator
   if (activePresets.includes('llm')) {
-    attributeFilters.push({
-      $typeName: 'redpanda.api.dataplane.v1alpha3.AttributeFilter',
-      key: 'gen_ai.operation.name',
-      operator: AttributeOperator.IN,
-      value: '',
-      values: ['chat', 'text_completion'],
-    });
+    attributeFilters.push(
+      create(AttributeFilterSchema, {
+        key: 'gen_ai.operation.name',
+        operator: AttributeOperator.IN,
+        values: ['chat', 'text_completion'],
+      })
+    );
   }
 
   // Tool filter → attribute filter
   if (activePresets.includes('tool')) {
-    attributeFilters.push({
-      $typeName: 'redpanda.api.dataplane.v1alpha3.AttributeFilter',
-      key: 'gen_ai.operation.name',
-      operator: AttributeOperator.EQUALS,
-      value: 'execute_tool',
-      values: [],
-    });
+    attributeFilters.push(
+      create(AttributeFilterSchema, {
+        key: 'gen_ai.operation.name',
+        operator: AttributeOperator.EQUALS,
+        value: 'execute_tool',
+      })
+    );
   }
 
   // Agent filter → attribute filter
   if (activePresets.includes('agent')) {
-    attributeFilters.push({
-      $typeName: 'redpanda.api.dataplane.v1alpha3.AttributeFilter',
-      key: 'gen_ai.operation.name',
-      operator: AttributeOperator.EQUALS,
-      value: 'invoke_agent',
-      values: [],
-    });
+    attributeFilters.push(
+      create(AttributeFilterSchema, {
+        key: 'gen_ai.operation.name',
+        operator: AttributeOperator.EQUALS,
+        value: 'invoke_agent',
+      })
+    );
   }
 
   // Add user-defined attribute filters
   for (const f of urlAttrFilters) {
-    attributeFilters.push({
-      $typeName: 'redpanda.api.dataplane.v1alpha3.AttributeFilter',
-      key: f.key,
-      operator: f.op === 'equals' ? AttributeOperator.EQUALS : AttributeOperator.NOT_EQUALS,
-      value: f.value,
-      values: [],
-    });
+    attributeFilters.push(
+      create(AttributeFilterSchema, {
+        key: f.key,
+        operator: f.op === 'equals' ? AttributeOperator.EQUALS : AttributeOperator.NOT_EQUALS,
+        value: f.value,
+      })
+    );
   }
 
-  return {
-    $typeName: 'redpanda.api.dataplane.v1alpha3.ListTracesRequest.Filter',
+  return create(ListTracesRequest_FilterSchema, {
     startTime: startTimestamp,
     endTime: endTimestamp,
     attributeFilters,
@@ -268,7 +270,7 @@ const buildApiFilter = ({
     serviceNames: serviceNames.length > 0 ? serviceNames : [],
     // Span ID filter - not exposed in UI yet, but required by proto
     spanIds: [],
-  };
+  });
 };
 
 type TranscriptListPageProps = {