Skip to content

perf(frontend): unshare lucide-react over Module Federation #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malinskibeniamin merged 1 commit into from
Jun 19, 2026
+6 −5
Merged

perf(frontend): unshare lucide-react over Module Federation #2516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions frontend/module-federation.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,12 @@ export const moduleFederationConfig: ModuleFederationPluginOptions = {
singleton: true,
requiredVersion: deps.zod,
},
'lucide-react': {
singleton: true,
requiredVersion: deps['lucide-react'],
eager: false,
},
// lucide-react is intentionally NOT shared. It is stateless SVG components
// (no context/hooks), so it has no singleton requirement. Sharing it as a
// singleton forced the whole package (~1.5 MiB / 1700+ icons) into a shared
// chunk regardless of which icons are used; unshared, this remote tree-shakes
// to only the icons it imports and can upgrade lucide independently of the
// cloud-ui host. The host and the adp-ui remote unshare it too.
'class-variance-authority': {
singleton: false,
requiredVersion: deps['class-variance-authority'],
Expand Down
Loading