style(sql): readable contrast for SQL editor identifiers#2535
Open
c-julin wants to merge 1 commit into
Open
Conversation
Contributor
✅ Clean — no registry drift, off-token colours, or ad-hoc classesApp:
Generated by lookout audit-changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The SQL editor renders plain identifiers (table/column names like
default_redpanda_catalog,cars) with--color-foreground(grey-700 light / grey-200 dark). Against the editor'sbg-backgroundsurface that reads faint — the bold keywords stand out but the identifier text washes out.This switches identifiers to
--color-strong(grey-900 light / grey-100 dark), the high-contrast primary-text token, so code is clearly readable. Still a semantic theme token (no off-palette literals), so it tracks light/dark automatically.Change
One line in
sql-editor.tsx'ssqlHighlight().