Skip to content

style(sql): readable contrast for SQL editor identifiers#2535

Open
c-julin wants to merge 1 commit into
masterfrom
jc/sql-editor-identifier-contrast
Open

style(sql): readable contrast for SQL editor identifiers#2535
c-julin wants to merge 1 commit into
masterfrom
jc/sql-editor-identifier-contrast

Conversation

@c-julin

@c-julin c-julin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What

The SQL editor renders plain identifiers (table/column names like default_redpanda_catalog, cars) with --color-foreground (grey-700 light / grey-200 dark). Against the editor's bg-background surface that reads faint — the bold keywords stand out but the identifier text washes out.

This switches identifiers to --color-strong (grey-900 light / grey-100 dark), the high-contrast primary-text token, so code is clearly readable. Still a semantic theme token (no off-palette literals), so it tracks light/dark automatically.

Change

- { tag: tags.name, color: 'var(--color-foreground)' },
+ { tag: tags.name, color: 'var(--color-strong)' },

One line in sql-editor.tsx's sqlHighlight().

@github-actions

Copy link
Copy Markdown
Contributor

Clean — no registry drift, off-token colours, or ad-hoc classes

App: frontend · Scope: diff vs origin/master · Files: 1

Count
⚠️ Outdated registry components 0
🛠 Locally-modified components 0
❓ Unknown to registry 0
🎨 Off-token palette colours 0
🔢 Ad-hoc utility classes 0

Generated by lookout audit-changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant