task: directory cleanup

Author: gene-redpanda

.tasks/ansible.yml

@@ -9,12 +9,14 @@ tasks:
 
   collection:
     desc: Install Ansible collections
+    deps:
+      - :ensure-collections-dir
     cmds:
-      - mkdir -p {{.ANSIBLE_COLLECTIONS_PATH}}
       - ansible-galaxy collection install -r {{.USER_WORKING_DIR}}/requirements.yml --force -p {{.ANSIBLE_COLLECTIONS_PATH}}
 
   role:
     desc: Install Ansible roles
+    deps:
+      - :ensure-roles-dir
     cmds:
-      - mkdir -p {{.ANSIBLE_ROLES_PATH}}
       - ansible-galaxy role install -r {{.USER_WORKING_DIR}}/requirements.yml --force -p {{.ANSIBLE_ROLES_PATH}}

.tasks/certificates.yml

@@ -10,8 +10,9 @@ tasks:
 
   client:key:
     desc: Generate client private key
+    deps:
+      - :ensure-client-dir
     cmds:
-      - mkdir -p {{.CLIENT_DIR}}
       - openssl genrsa -out {{.CLIENT_DIR}}/{{.CLIENT_NAME}}.key 2048
     generates:
       - "{{.CLIENT_DIR}}/{{.CLIENT_NAME}}.key"

.tasks/cluster.yml

@@ -5,54 +5,54 @@ tasks:
     desc: Provision Redpanda cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   tls:
     desc: Provision Redpanda cluster with TLS
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster-tls.yml --private-key {{.PRIVATE_KEY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   tiered:
     desc: Provision Redpanda cluster with tiered storage
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster-tiered-storage.yml --private-key {{.PRIVATE_KEY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}} --extra-vars segment_upload_interval={{.SEGMENT_UPLOAD_INTERVAL}} --extra-vars cloud_storage_credentials_source={{.CLOUD_STORAGE_CREDENTIALS_SOURCE}} --extra-vars redpanda_license={{.REDPANDA_LICENSE}}
 
   proxy:
     desc: Provision Redpanda cluster with proxy
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/proxy/provision-private-proxied-cluster.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}} --extra-vars '{"squid_acl_localnet":["{{.SQUID_ACL_LOCALNET}}"]}' --extra-vars redpanda='{"cluster":{"cloud_storage_segment_max_upload_interval_sec":"{{.SEGMENT_UPLOAD_INTERVAL}}"}}' {{.SKIP_TAGS}} {{.CLI_ARGS}}
 
   extra:provision:
     desc: Provision secondary Redpanda cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   extra:tls:
     desc: Provision secondary cluster with TLS
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   dev:tiered:
     desc: Development tiered storage deployment (no log suppression)
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/provision-cluster-tiered-storage.yml --private-key {{.PRIVATE_KEY}} --extra-vars redpanda_broker_no_log=false --extra-vars development_build=true --extra-vars segment_upload_interval={{.SEGMENT_UPLOAD_INTERVAL}} --extra-vars cloud_storage_credentials_source={{.CLOUD_STORAGE_CREDENTIALS_SOURCE}}

.tasks/connect.yml

@@ -43,8 +43,8 @@ tasks:
       ENABLE_CONNECT: "true"
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-connect.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   provision:tls:
@@ -53,8 +53,8 @@ tasks:
       ENABLE_CONNECT: "true"
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-connect-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   extra:copy-rpm:

.tasks/infrastructure.yml

@@ -133,8 +133,9 @@ tasks:
   # Extra AWS cluster for mirroring/testing
   extra:aws:copy:
     desc: Copy AWS terraform files for secondary cluster
+    deps:
+      - :ensure-aws-extra-dir
     cmds:
-      - mkdir -p aws-extra
       - find aws -maxdepth 1 -name "*.tf" -exec cp {} aws-extra/ \;
       - test -f aws/README.md && cp aws/README.md aws-extra/ || true
 

.tasks/monitoring.yml

@@ -5,63 +5,63 @@ tasks:
     desc: Deploy monitoring stack (Prometheus/Grafana)
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES
       - ansible-playbook ansible/deploy-monitor.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   deploy:tls:
     desc: Deploy monitoring stack with TLS
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-monitor-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   extra:deploy:
     desc: Deploy monitoring on secondary cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-monitor.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   extra:deploy:tls:
     desc: Deploy monitoring with TLS on secondary cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-monitor-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   console:deploy:
     desc: Deploy Redpanda Console
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-console.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   console:deploy:tls:
     desc: Deploy Redpanda Console with TLS
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-console-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   console:extra:deploy:
     desc: Deploy Console on secondary cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-console.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}
 
   console:extra:deploy:tls:
     desc: Deploy Console with TLS on secondary cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/deploy-console-tls.yml --private-key {{.PRIVATE_KEY}} --inventory {{.EXTRA_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}}

.tasks/operations.yml

@@ -5,30 +5,30 @@ tasks:
     desc: Configure Redpanda logging
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/operation-configure-logging.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars is_using_unstable={{.IS_USING_UNSTABLE}} --extra-vars redpanda_logging_log_file={{.REDPANDA_LOGGING_LOG_FILE}}
 
   connect:restart:
     desc: Perform rolling restart of Redpanda Connect cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/operation-rolling-restart-connect.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}}
 
   broker:restart:
     desc: Perform rolling restart of Redpanda broker cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/operation-rolling-restart.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}}
 
   license:apply:
     desc: Apply Redpanda license to the cluster
     deps:
       - :ansible:prereqs
+      - :ensure-logs-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/logs
       - ansible-playbook ansible/operation-apply-license.yml --private-key {{.PRIVATE_KEY}} --inventory {{.ANSIBLE_INVENTORY}} --extra-vars redpanda_license={{.REDPANDA_LICENSE}}

.tasks/tools.yml

@@ -13,9 +13,10 @@ tasks:
 
   rpk:install:
     desc: Download and install rpk CLI tool
+    deps:
+      - :ensure-tmp-dir
+      - :ensure-bin-dir
     cmds:
-      - mkdir -p {{.ARTIFACT_DIR}}/tmp
-      - mkdir -p {{.ARTIFACT_DIR}}/bin
       - |
         if [ "$(uname)" = "Darwin" ]; then
           curl -L {{.MAC_RPK}} -o {{.ARTIFACT_DIR}}/tmp/rpk.zip

Taskfile.yml

@@ -180,3 +180,73 @@ tasks:
     cmds:
       - task --list-all
     silent: true
+
+  ensure-logs-dir:
+    desc: Ensure artifacts logs directory exists
+    cmds:
+      - mkdir -p {{.ARTIFACT_DIR}}/logs
+    status:
+      - test -d {{.ARTIFACT_DIR}}/logs
+    generates:
+      - "{{.ARTIFACT_DIR}}/logs"
+    silent: true
+
+  ensure-tmp-dir:
+    desc: Ensure artifacts tmp directory exists
+    cmds:
+      - mkdir -p {{.ARTIFACT_DIR}}/tmp
+    status:
+      - test -d {{.ARTIFACT_DIR}}/tmp
+    generates:
+      - "{{.ARTIFACT_DIR}}/tmp"
+    silent: true
+
+  ensure-bin-dir:
+    desc: Ensure artifacts bin directory exists
+    cmds:
+      - mkdir -p {{.ARTIFACT_DIR}}/bin
+    status:
+      - test -d {{.ARTIFACT_DIR}}/bin
+    generates:
+      - "{{.ARTIFACT_DIR}}/bin"
+    silent: true
+
+  ensure-collections-dir:
+    desc: Ensure ansible collections directory exists
+    cmds:
+      - mkdir -p {{.ANSIBLE_COLLECTIONS_PATH}}
+    status:
+      - test -d {{.ANSIBLE_COLLECTIONS_PATH}}
+    generates:
+      - "{{.ANSIBLE_COLLECTIONS_PATH}}"
+    silent: true
+
+  ensure-roles-dir:
+    desc: Ensure ansible roles directory exists
+    cmds:
+      - mkdir -p {{.ANSIBLE_ROLES_PATH}}
+    status:
+      - test -d {{.ANSIBLE_ROLES_PATH}}
+    generates:
+      - "{{.ANSIBLE_ROLES_PATH}}"
+    silent: true
+
+  ensure-client-dir:
+    desc: Ensure TLS client directory exists
+    cmds:
+      - mkdir -p {{.CLIENT_DIR}}
+    status:
+      - test -d {{.CLIENT_DIR}}
+    generates:
+      - "{{.CLIENT_DIR}}"
+    silent: true
+
+  ensure-aws-extra-dir:
+    desc: Ensure aws-extra directory exists
+    cmds:
+      - mkdir -p aws-extra
+    status:
+      - test -d aws-extra
+    generates:
+      - "aws-extra"
+    silent: true