Fix minor typo in object-storage-properties.adoc#1087
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe documentation for the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/reference/pages/properties/object-storage-properties.adoc (1)
539-543: Ensure consistency in accepted values formatting
The*Accepted values*line forcloud_storage_credentials_sourcecurrently uses inline backticks without square brackets and lists the Azure entries in reverse order compared tocloud_storage_credentials_host. To align with surrounding properties, please:
- Use the square-bracket notation for value lists.
- Order Azure entries as
azure_aks_oidc_federationbeforeazure_vm_instance_metadata.Apply this diff:
- *Accepted values*: `config_file`, `aws_instance_metadata`, `sts`, `gcp_instance_metadata`, `azure_vm_instance_metadata`, `azure_aks_oidc_federation` + *Accepted values:* [`config_file`, `aws_instance_metadata`, `sts`, `gcp_instance_metadata`, `azure_aks_oidc_federation`, `azure_vm_instance_metadata`]
|
@Feediver1 If you can point me to how to do backports, happy to do the legwork to sort them too :) |
Thanks @JFlath! I think this slipped through the cracks, but I'll merge it now. For backporting, you can either make the change in the |
Checks
Summary by CodeRabbit
cloud_storage_credentials_sourceproperty to clearly liststsandgcp_instance_metadataas separate options.