docs: add redpanda_trust_file_crc32c and redpanda_truststore_expires_at_timestamp_seconds metrics#1236
Conversation
…at_timestamp_seconds metrics
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughTwo new public metrics have been added to the documentation in the TLS metrics section. The first metric, Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/reference/pages/public-metrics-reference.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (2)
modules/reference/pages/public-metrics-reference.adoc (2)
1895-1899: Label set diverges from established TLS metric conventionsExisting TLS metrics use
areaanddetaillabels, e.g.redpanda_tls_certificate_valid.
The newly added gauges introduceaggregates,label, andshard(andlabel_instance). Unless the exporter really emits these label names, this creates inconsistent cardinality and increases PromQL boilerplate.Confirm the authoritative label list emitted by Redpanda and harmonise with the earlier TLS metrics.
1903-1908: Clarify duplicate metric entry and update documentation accordinglyThere are two seemingly identical gauges in
modules/reference/pages/public-metrics-reference.adoc:
- Line 1782:
redpanda_tls_truststore_expires_at_timestamp_seconds- Line 1903:
redpanda_truststore_expires_at_timestamp_secondsPlease confirm with the owning team or by inspecting the exporter code which metric name is actually emitted. Then choose one of the following:
- If the metric has been renamed to drop
tls_, mark the old name deprecated (with removal timeline) and update its documentation accordingly.- If the new entry was added by mistake, delete it to avoid duplicate documentation.
Description
Resolves https://redpandadata.atlassian.net/browse/DOC-177
Review deadline: 28th July
Page previews
redpanda_trust_file_crc32c
redpanda_truststore_expires_at_timestamp_seconds
Checks