Skip to content

Enclose secrets in single quotes #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbatuigas merged 3 commits into from
Aug 26, 2025
Merged

Enclose secrets in single quotes #1340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38fc5bb
Enclose secrets in single quotes
kbatuigas Aug 25, 2025
4df6160
Accept suggestion from automated review
kbatuigas Aug 26, 2025
f010b83
Add oauth uri to cluster config example
kbatuigas Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/manage/pages/iceberg/iceberg-topics-aws-glue.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ rpk cluster config set \
iceberg_rest_catalog_base_location=s3://<bucket-name>/<warehouse-path>
iceberg_rest_catalog_aws_region=<glue-region>
iceberg_rest_catalog_aws_access_key=<glue-access-key>
iceberg_rest_catalog_aws_secret_key=${secrets.<glue-secret-key-name>}
iceberg_rest_catalog_aws_secret_key='${secrets.<glue-secret-key-name>}'
----
+
Use your own values for the following placeholders:
Expand Down
2 changes: 1 addition & 1 deletion modules/manage/pages/iceberg/iceberg-topics-databricks-unity.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ rpk cluster config set \
iceberg_rest_catalog_oauth2_server_uri=https://<workspace-instance>/oidc/v1/token \
iceberg_rest_catalog_oauth2_scope=all-apis \
iceberg_rest_catalog_client_id=<service-principal-client-id> \
iceberg_rest_catalog_client_secret=${secrets.<service-principal-client-secret-name>} \
iceberg_rest_catalog_client_secret='${secrets.<service-principal-client-secret-name>}' \
iceberg_rest_catalog_warehouse=<unity-catalog-name> \
iceberg_disable_snapshot_tagging=true
----
Expand Down
2 changes: 1 addition & 1 deletion modules/manage/pages/iceberg/redpanda-topics-iceberg-snowflake-catalog.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ rpk cluster config set \
iceberg_rest_catalog_endpoint=https://<snowflake-orgname>-<open-catalog-account-name>.snowflakecomputing.com/polaris/api/catalog \
iceberg_rest_catalog_authentication_mode=oauth2 \
iceberg_rest_catalog_client_id=<open-catalog-connection-client-id> \
iceberg_rest_catalog_client_secret=${secrets.<open-catalog-client-secret-name>} \
iceberg_rest_catalog_client_secret='${secrets.<open-catalog-client-secret-name>}' \
iceberg_rest_catalog_warehouse=<open-catalog-name>

# Optional properties:
Expand Down
2 changes: 1 addition & 1 deletion modules/manage/partials/iceberg/use-iceberg-catalogs.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ rpk::
--
[,bash]
----
rpk cluster config set iceberg_rest_catalog_client_secret ${secrets.<secret-name>}
rpk cluster config set iceberg_rest_catalog_client_secret '${secrets.<secret-name>}'
----
--

Expand Down