Skip to content

Update iceberg-topics-aws-glue.adoc#1375

Merged
kbatuigas merged 1 commit intomainfrom
nvartolomei-patch-1
Oct 6, 2025
Merged

Update iceberg-topics-aws-glue.adoc#1375
kbatuigas merged 1 commit intomainfrom
nvartolomei-patch-1

Conversation

@nvartolomei
Copy link
Copy Markdown
Contributor

Add missing backslash. Funny things happen otherwise when copy-pasted.

Description

Resolves https://redpandadata.atlassian.net/browse/
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Add missing backslash. Funny things happen otherwise when copy-pasted.
@nvartolomei nvartolomei requested a review from a team as a code owner October 5, 2025 20:06
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 5, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit b927bda
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/68e2cfddc666a10008414ab3
😎 Deploy Preview https://deploy-preview-1375--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nvartolomei nvartolomei requested a review from kbatuigas October 5, 2025 20:06
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 5, 2025

📝 Walkthrough

Walkthrough

The PR updates documentation in modules/manage/pages/iceberg/iceberg-topics-aws-glue.adoc by adding line-continuation backslashes to the shell snippet where iceberg_rest_catalog_credentials_source=config_file appears, splitting single-line commands into multi-line commands in two places. No code or logic changes; only documentation formatting is altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • simon0191
  • mattschumpert

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description follows the template structure but leaves the Jira ticket placeholder and review deadline blank and does not include any actual page preview URLs, so the required information is incomplete. Please replace the Jira ticket placeholder with the actual ticket number, specify a review deadline if needed, and add the Netlify page preview links under the Page previews section.
Title Check ❓ Inconclusive The pull request title “Update iceberg-topics-aws-glue.adoc” is related to the changeset but is too generic and does not convey the specific update of adding a missing backslash in the documentation snippet. Please revise the title to be more descriptive of the actual change, for example “Add missing line continuation backslashes to AWS Glue snippet in iceberg-topics-aws-glue.adoc.”
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nvartolomei-patch-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 06162ab and b927bda.

📒 Files selected for processing (1)
  • modules/manage/pages/iceberg/iceberg-topics-aws-glue.adoc (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@kbatuigas kbatuigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nvartolomei ! I'll go ahead and merge this for you.

@kbatuigas kbatuigas merged commit 33e9ec9 into main Oct 6, 2025
7 checks passed
@kbatuigas kbatuigas deleted the nvartolomei-patch-1 branch October 6, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants