-
Notifications
You must be signed in to change notification settings - Fork 50
feat(DOC-2012): document Kafka 4.x client compatibility and KIP-890 #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mfernest
wants to merge
6
commits into
main
Choose a base branch
from
feat/doc-2012-kafka4x-compatibility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−14
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
061552a
feat(DOC-2012): document Kafka 4.x client compatibility and KIP-890
mfernest 30ce813
style(DOC-2012): apply style guide audit to kafka-clients.adoc
mfernest 12c83ea
Merge remote-tracking branch 'origin/main' into feat/doc-2012-kafka4x…
mfernest 9eeb533
docs(DOC-2012): explain why KIP-890 is not needed in Redpanda
mfernest ca76612
Merge remote-tracking branch 'origin/main' into feat/doc-2012-kafka4x…
mfernest 3f7a739
fix(DOC-2012): clarify KIP-890 fallback behavior per bashtanov review
mfernest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks confusing to me. Kafka 4.x clients assume per-transaction epoch bumping only when connected to a server supporting Transactions V2 protocol, which Kafka supports but Redpanda doesn't. Not bumping the epoch on every transaction is part of falling back to the old transactions protocol.