operator: Accept *RaftConfiguration by pointer in NewRaftRuntimeManager

RaftConfiguration is a large struct (rest.Config, logr.Logger, scheme,
peers list, etc.). Passing it by value copied all fields on every call.
Change the parameter to a pointer to avoid the unnecessary copy.

Author: RafalKorepta

operator/internal/testenv/testenv.go

@@ -290,7 +290,7 @@ func (e *Env) SetupMulticlusterManager(serviceAccount string, address string, pe
 		config.Impersonate.UserName = fmt.Sprintf("system:serviceaccount:%s:%s", e.Namespace(), serviceAccount)
 	}
 
-	manager, err := multicluster.NewRaftRuntimeManager(multicluster.RaftConfiguration{
+	manager, err := multicluster.NewRaftRuntimeManager(&multicluster.RaftConfiguration{
 		Name:               e.Name,
 		Address:            address,
 		Peers:              peers,

pkg/multicluster/raft.go

@@ -212,7 +212,7 @@ func (r RaftConfiguration) validate() error {
 
 // NewRaftRuntimeManager creates a Manager backed by raft-based cross-cluster
 // leader election. Only the raft leader's manager starts controller runnables.
-func NewRaftRuntimeManager(config RaftConfiguration) (Manager, error) {
+func NewRaftRuntimeManager(config *RaftConfiguration) (Manager, error) {
 	if err := config.validate(); err != nil {
 		return nil, err
 	}