operator: Replace otelutil/log with controller-runtime/pkg/log#1427
Closed
RafalKorepta wants to merge 1 commit intomainfrom
Closed
operator: Replace otelutil/log with controller-runtime/pkg/log#1427RafalKorepta wants to merge 1 commit intomainfrom
RafalKorepta wants to merge 1 commit intomainfrom
Conversation
RafalKorepta
requested review from
andrewstucki,
chrisseto,
gene-redpanda and
hidalgopl
as code owners
RafalKorepta
force-pushed
the
rk/remove-context-from-log-line
branch
2 times, most recently
from
d22bc43 to
e300345
Compare
Work around the noisy "ctx" key-value pair that common-go's otelutil/log appends to every log line, serializing the full context.Context wrapper chain (e.g. "context.Background.WithCancel.WithCancel.WithValue(...)"). Switch all call sites from log.Info(ctx, ...) / log.Error(ctx, err, ...) to the standard controller-runtime pattern: log := log.FromContext(ctx) followed by log.Info(...) / log.Error(err, ...). This is a temporary workaround until redpanda-data/common-go#160 lands, after which we can revert back to otelutil/log. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RafalKorepta
force-pushed
the
rk/remove-context-from-log-line
branch
from
e300345 to
58b5fd1
Compare
Contributor
Author
|
The #1436 has proper fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work around the noisy "ctx" key-value pair that common-go's otelutil/log appends to every log line, serializing the full context.Context wrapper chain (e.g. "context.Background.WithCancel.WithCancel.WithValue(...)").
Switch all call sites from log.Info(ctx, ...) / log.Error(ctx, err, ...) to the standard controller-runtime pattern: log := log.FromContext(ctx) followed by log.Info(...) / log.Error(err, ...).
This is a temporary workaround until redpanda-data/common-go#160 lands, after which we can revert back to otelutil/log.