Merge pull request #30259 from joe-redpanda/cluster-breakup-cleanup

Cut down on //src/v/cluster use

Author: joe-redpanda

src/v/cloud_storage/inventory/tests/BUILD

@@ -99,7 +99,6 @@ redpanda_cc_gtest(
         "//src/v/cloud_storage:types",
         "//src/v/cloud_storage/inventory/tests:common",
         "//src/v/cloud_storage_clients",
-        "//src/v/cluster",
         "//src/v/cluster:inventory_service",
         "//src/v/model",
         "//src/v/test_utils:gtest",

src/v/cloud_storage/tests/BUILD

@@ -251,7 +251,6 @@ redpanda_cc_btest(
         "//src/v/bytes:iostream",
         "//src/v/cloud_storage",
         "//src/v/cloud_storage:types",
-        "//src/v/cluster",
         "//src/v/model",
         "//src/v/test_utils:seastar_boost",
         "@boost//:test",
@@ -285,7 +284,6 @@ redpanda_cc_gtest(
         "//src/v/cloud_storage",
         "//src/v/cloud_storage:remote_label",
         "//src/v/cloud_storage:types",
-        "//src/v/cluster",
         "//src/v/cluster:types",
         "//src/v/model",
         "//src/v/test_utils:gtest",
@@ -309,7 +307,6 @@ redpanda_cc_btest(
         "//src/v/cloud_storage",
         "//src/v/cloud_storage:topic_path_utils",
         "//src/v/cloud_storage:types",
-        "//src/v/cluster",
         "//src/v/cluster:types",
         "//src/v/model",
         "//src/v/test_utils:random",

src/v/cloud_topics/level_one/compaction/tests/BUILD

@@ -105,7 +105,6 @@ redpanda_cc_gtest(
         "//src/v/cloud_topics/level_one/compaction:log_info_collector",
         "//src/v/cloud_topics/level_one/compaction:meta",
         "//src/v/cloud_topics/level_one/frontend_reader/tests:l1_reader_fixture",
-        "//src/v/cluster",
         "//src/v/cluster:fwd",
         "//src/v/cluster:members_table",
         "//src/v/cluster:partition_leaders_table",
@@ -130,7 +129,6 @@ redpanda_cc_gtest(
     ],
     deps = [
         "//src/v/cloud_topics/level_one/compaction:log_collector",
-        "//src/v/cluster",
         "//src/v/cluster:commands",
         "//src/v/cluster:data_migrated_resources",
         "//src/v/cluster:fwd",
@@ -157,7 +155,6 @@ redpanda_test_cc_library(
         "//src/v/cloud_topics/level_one/compaction:scheduling_policies",
         "//src/v/cloud_topics/level_one/compaction:worker",
         "//src/v/cloud_topics/level_one/frontend_reader/tests:l1_reader_fixture",
-        "//src/v/cluster",
         "//src/v/cluster:topic_configuration",
         "//src/v/container:chunked_hash_map",
         "//src/v/model",
@@ -233,7 +230,6 @@ redpanda_cc_gtest(
     deps = [
         "//src/v/cloud_io/tests:s3_imposter",
         "//src/v/cloud_topics/level_zero/stm:ctp_stm",
-        "//src/v/cluster",
         "//src/v/cluster:cluster_utils",
         "//src/v/cluster:controller_log_limiter",
         "//src/v/cluster:data_migration_table",

src/v/cloud_topics/level_one/metastore/tests/BUILD

@@ -165,7 +165,6 @@ redpanda_cc_gtest(
         "//src/v/cloud_io:remote",
         "//src/v/cloud_topics/level_one/metastore:simple",
         "//src/v/cloud_topics/level_one/metastore:topic_purger",
-        "//src/v/cluster",
         "//src/v/cluster:data_migrated_resources",
         "//src/v/cluster:nt_revision",
         "//src/v/cluster:topic_table",

src/v/cloud_topics/tests/BUILD

@@ -133,7 +133,6 @@ redpanda_cc_gtest(
         ":cluster_fixture",
         "//src/v/base",
         "//src/v/cloud_storage",
-        "//src/v/cluster",
         "//src/v/cluster:fwd",
         "//src/v/cluster:inventory_service",
         "//src/v/cluster:leader_balancer_strategy",

src/v/cluster/BUILD

@@ -1065,9 +1065,16 @@ redpanda_cc_library(
 
 redpanda_cc_library(
     name = "drain_status",
+    srcs = [
+        "drain_status.cc",
+    ],
     hdrs = [
         "drain_status.h",
     ],
+    implementation_deps = [
+        "//src/v/base",
+        "@fmt",
+    ],
     visibility = ["//visibility:public"],
     deps = [
         "//src/v/serde",

src/v/cluster/archival/tests/BUILD

@@ -320,7 +320,6 @@ redpanda_cc_btest(
     memory = "2048MiB",
     deps = [
         ":archival_service_fixture",
-        "//src/v/cluster",
         "//src/v/cluster:cluster_utils",
         "//src/v/cluster:data_migration_table",
         "//src/v/cluster:errc",

src/v/cluster/cloud_metadata/tests/BUILD

@@ -41,7 +41,6 @@ redpanda_cc_gtest(
     ],
     deps = [
         "//src/v/bytes:iostream",
-        "//src/v/cluster",
         "//src/v/cluster:cloud_metadata_cluster_manifest",
         "//src/v/test_utils:gtest",
         "@googletest//:gtest",
@@ -139,7 +138,6 @@ redpanda_cc_gtest(
         ":manual_mixin",
         "//src/v/cloud_io/tests:s3_imposter",
         "//src/v/cloud_storage",
-        "//src/v/cluster",
         "//src/v/cluster:cloud_metadata_cluster_manifest",
         "//src/v/cluster:cloud_metadata_key_utils",
         "//src/v/cluster:cloud_metadata_manifest_downloads",
@@ -198,7 +196,6 @@ redpanda_cc_gtest(
     cpu = 1,
     deps = [
         "//src/v/cloud_io/tests:s3_imposter",
-        "//src/v/cluster",
         "//src/v/cluster:cluster_utils",
         "//src/v/cluster:controller_log_limiter",
         "//src/v/cluster:data_migration_table",
@@ -290,7 +287,6 @@ redpanda_cc_gtest(
     ],
     cpu = 1,
     deps = [
-        "//src/v/cluster",
         "//src/v/cluster:cloud_metadata_key_utils",
         "//src/v/test_utils:gtest",
         "@googletest//:gtest",

src/v/cluster/cluster_link/tests/BUILD

@@ -28,7 +28,6 @@ redpanda_cc_gtest(
     ],
     deps = [
         ":test_lib",
-        "//src/v/cluster",
         "//src/v/cluster:cluster_link_rpc_types",
         "//src/v/cluster:cluster_link_table",
         "//src/v/cluster:commands",

src/v/cluster/drain_manager.cc

@@ -1,6 +1,5 @@
 #include "cluster/drain_manager.h"
 
-#include "base/format_to.h"
 #include "base/vlog.h"
 #include "cluster/logger.h"
 #include "cluster/partition_manager.h"
@@ -283,17 +282,5 @@ ss::future<> drain_manager::do_restore() {
     _partition_manager.local().unblock_new_leadership();
     co_return;
 }
-fmt::iterator drain_status::format_to(fmt::iterator it) const {
-    return fmt::format_to(
-      it,
-      "{{finished: {}, errors: {}, partitions: {}, eligible: {}, transferring: "
-      "{}, failed: {}}}",
-      finished,
-      errors,
-      partitions,
-      eligible,
-      transferring,
-      failed);
-}
 
 } // namespace cluster