clang-tidy: Fix various C++ errors

 - src/v/utils/retry_chain_node.h — Fixed bugprone-use-after-move:
   format message once upfront instead of double-forwarding args.
 - src/v/cluster/partition_leaders_table.h — Fixed
   bugprone-use-after-move: capture f by reference instead of forwarding
   into a lambda inside a loop.
 - src/v/test_utils/randoms.h — Fixed bugprone-use-after-move: don't
   forward args in a loop, just pass them as lvalues.

Author: StephanDollberg

src/v/cluster/inventory_service.cc

@@ -116,8 +116,7 @@ default_leaders_provider::ntps(ss::abort_source& as) {
         std::exception_ptr ep;
         try {
             co_await _leaders_table.local().for_each_leader(
-              [&ntps,
-               self_node_id](auto tp_ns, auto pid, auto node_id, auto) mutable {
+              [&ntps, self_node_id](auto tp_ns, auto pid, auto node_id, auto) {
                   if (node_id == self_node_id) {
                       ntps.insert(model::ntp{tp_ns.ns, tp_ns.tp, pid});
                   }

src/v/cluster/metadata_dissemination_handler.cc

@@ -85,7 +85,7 @@ make_get_leadership_reply(partition_leaders_table& leaders) {
                                            model::topic_namespace_view tp_ns,
                                            model::partition_id pid,
                                            std::optional<model::node_id> leader,
-                                           model::term_id term) mutable {
+                                           model::term_id term) {
             ret.emplace_back(model::ntp(tp_ns.ns, tp_ns.tp, pid), term, leader);
         });
         co_return get_leadership_reply{

src/v/cluster/partition_leaders_table.h

@@ -78,7 +78,7 @@ class partition_leaders_table {
       model::term_id term) {
         { f(tp_ns, pid, leader, term) } -> std::same_as<void>;
     }
-    ss::future<> for_each_leader(Func&& f) {
+    ss::future<> for_each_leader(const Func& f) {
         auto holder = _gate.hold();
         auto u = co_await _mutex.get_units();
         ssx::async_counter counter;
@@ -87,8 +87,7 @@ class partition_leaders_table {
               counter,
               partition_leaders.begin(),
               partition_leaders.end(),
-              [&tp_ns, f = std::forward<Func>(f)](
-                const partition_leaders::value_type& p) mutable {
+              [&tp_ns, &f](const partition_leaders::value_type& p) {
                   f(tp_ns,
                     model::partition_id(p.first),
                     p.second.current_leader,

src/v/test_utils/randoms.h

@@ -83,25 +83,26 @@ auto random_chunked_vector(Fn&& gen, size_t size = 20) -> chunked_vector<T> {
 template<
   typename Fn,
   typename... Args,
-  typename T = std::invoke_result_t<Fn, Args...>>
-inline auto random_frag_vector(Fn&& gen, size_t size = 20, Args&&... args)
+  typename T = std::invoke_result_t<Fn, Args&&...>>
+inline auto random_frag_vector(const Fn& gen, size_t size = 20, Args&&... args)
   -> chunked_vector<T> {
     chunked_vector<T> v;
     while (size-- > 0) {
-        v.push_back(gen(std::forward<Args>(args)...));
+        v.push_back(gen(args...));
     }
     return v;
 }
 
 template<
   typename Fn,
   typename... Args,
-  typename T = std::invoke_result_t<Fn, Args...>>
-inline auto random_chunked_vector(Fn&& gen, size_t size = 20, Args&&... args)
+  typename T = std::invoke_result_t<Fn, const Args&...>>
+inline auto
+random_chunked_vector(Fn&& gen, size_t size = 20, const Args&... args)
   -> chunked_vector<T> {
     chunked_vector<T> v;
     while (size-- > 0) {
-        v.push_back(gen(std::forward<Args>(args)...));
+        v.push_back(gen(args...));
     }
     return v;
 }

src/v/utils/retry_chain_node.h

@@ -634,23 +634,19 @@ class basic_retry_chain_logger final {
     void
     log(ss::log_level lvl, fmt::format_string<Args...> format, Args&&... args)
       const {
-        std::optional<ss::sstring> trace;
+        if (!_has_tracing && !_log.is_enabled(lvl)) {
+            return;
+        }
+        auto msg = ssx::sformat(format, std::forward<Args>(args)...);
         if (_has_tracing) {
-            trace = ssx::sformat(format, std::forward<Args>(args)...);
-            _node.maybe_add_trace(trace.value());
+            _node.maybe_add_trace(msg);
         }
         if (_log.is_enabled(lvl)) {
             auto lambda = [&](ss::logger& logger, ss::log_level lvl) {
-                auto msg = trace.value_or(
-                  ssx::sformat(format, std::forward<Args>(args)...));
                 if (_ctx) {
-                    logger.log(
-                      lvl,
-                      "{} - {}",
-                      _node("{}", _ctx.value()),
-                      std::move(msg));
+                    logger.log(lvl, "{} - {}", _node("{}", _ctx.value()), msg);
                 } else {
-                    logger.log(lvl, "{} - {}", _node(), std::move(msg));
+                    logger.log(lvl, "{} - {}", _node(), msg);
                 }
             };
             do_log(lvl, std::move(lambda));