Skip to content

storage: remove compaction_ratio metric from probe #29994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillemKauf merged 1 commit into from
Apr 7, 2026
Merged

storage: remove compaction_ratio metric from probe #29994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/v/storage/disk_log_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,8 +1413,6 @@ ss::future<> disk_log_impl::housekeeping(housekeeping_config cfg) {
std::rethrow_exception(fut.get_exception());
}
}

_probe->set_compaction_ratio(_compaction_ratio.get());
}

ss::future<> disk_log_impl::do_compact(
Expand Down
12 changes: 0 additions & 12 deletions src/v/storage/probe.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,18 +258,6 @@ void probe::setup_metrics(const model::ntp& ntp) {
},
{},
{sm::shard_label, metrics::partition_label});
Comment thread
WillemKauf marked this conversation as resolved.

_metrics.add_group(
group_name,
{
// compaction_ratio cannot easily be aggregated since aggregation always
// sums values and sum is nonsensical for a compaction ratio
sm::make_total_bytes(
"compaction_ratio",
[this] { return _compaction_ratio; },
sm::description("Average segment compaction ratio"),
labels),
});
}

void probe::add_initial_segment(const segment& s) {
Expand Down
2 changes: 0 additions & 2 deletions src/v/storage/probe.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ class probe {
size_t partition_size() const { return _partition_bytes; }
void add_initial_segment(const segment&);
void remove_partition_bytes(size_t remove) { _partition_bytes -= remove; }
void set_compaction_ratio(double r) { _compaction_ratio = r; }

int64_t get_batch_parse_errors() const { return _batch_parse_errors; }
/**
Expand Down Expand Up @@ -164,7 +163,6 @@ class probe {
uint32_t _batch_parse_errors = 0;
uint32_t _batch_write_errors = 0;

double _compaction_ratio = 1.0;
uint64_t _tombstones_removed = 0;
uint64_t _control_batches_removed = 0;
uint64_t _segment_cleanly_compacted = 0;
Expand Down
Loading