perf: Enable greedy leader balancer in all CPD tests#30047
Merged
StephanDollberg merged 1 commit intodevfrom Apr 8, 2026
Merged
perf: Enable greedy leader balancer in all CPD tests#30047StephanDollberg merged 1 commit intodevfrom
StephanDollberg merged 1 commit intodevfrom
Conversation
Enable greedy leader balancer unconditionally in CPD for more stable leadership behaviour.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a perf-test-specific base class that injects leader_balancer_mode=greedy into Redpanda configuration so CPD/perf tests run with more stable leadership behavior by default.
Changes:
- Added
RedpandaPerfTestwrapper overRedpandaTestto apply a defaultleader_balancer_mode=greedy. - Updated existing perf/CPD test classes to inherit from
RedpandaPerfTestinstead ofRedpandaTest. - Minor formatting adjustments to some
super().__init__calls while switching base classes.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rptest/perf/redpanda_perf_test.py | New base class that injects leader_balancer_mode=greedy into extra_rp_conf. |
| tests/rptest/perf/ts_write_openmessaging_test.py | Switch test to inherit from RedpandaPerfTest. |
| tests/rptest/perf/ts_read_single_consumer_omb.py | Switch test to inherit from RedpandaPerfTest. |
| tests/rptest/perf/ts_read_openmessaging_test.py | Switch test to inherit from RedpandaPerfTest. |
| tests/rptest/perf/small_batches_test.py | Switch test to inherit from RedpandaPerfTest. |
| tests/rptest/perf/rpk_benchmark_test.py | Switch test to inherit from RedpandaPerfTest (with minor formatting change). |
| tests/rptest/perf/openmessaging_perf_test.py | Switch test to inherit from RedpandaPerfTest. |
| tests/rptest/perf/datalake_test.py | Switch test to inherit from RedpandaPerfTest. |
travisdowns
approved these changes
Apr 2, 2026
Member
travisdowns
left a comment
travisdowns
left a comment
There was a problem hiding this comment.
Nice, looking forward to the plots flatlining :)
Member
Author
A man can dream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable greedy leader balancer unconditionally in CPD for more stable leadership behaviour.
Backports Required
Release Notes