[v25.3.x] dl/coordinator: add default formatter for errc#31006
Open
vbotbuildovich wants to merge 1 commit into
Open
[v25.3.x] dl/coordinator: add default formatter for errc#31006vbotbuildovich wants to merge 1 commit into
vbotbuildovich wants to merge 1 commit into
Conversation
This errc gets serialized over the wire, so it's possible for a binary to get unknown numeric values (e.g. future errors). The formatter previously didn't account for this and would result in UB when adding errc types. (cherry picked from commit a9b2926)
Collaborator
Author
CI test resultstest results on build#86683
|
Collaborator
Author
Retry command for Build#86683please wait until all jobs are finished before running the slash command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #31003
Conflict details
format_to(errc, ...)free function intypes.h, but thatformat_to-based formatter only exists on dev — v25.3.x still formatserrcviaoperator<<(std::ostream&, const errc&)declared intypes.hand defined intypes.cc(theoperator<<→format_tomigration is a separate, un-backported commit). Resolved by keeping the target branch'soperator<<declaration intypes.hand applying the commit's actual intent — gracefully formatting unknown/future numericerrcvalues — to theoperator<<definition intypes.cc. Mirrored dev's exhaustive-switch + post-switch fallback by converting the per-casebreaks to early returns and addingreturn o << fmt::format("errc::unknown({})", static_cast<int16_t>(errc));after the switch, preserving-Wswitchexhaustiveness checking.