feat(DOC-2008): document automatic topic creation for redpanda_migrator#395
Conversation
✅ Deploy Preview for redpanda-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
modules/components/pages/outputs/redpanda_migrator.adoc (1)
47-47: Consider clarifying that labels must match exactly.The paired input component's documentation states that "labels must match exactly" and explains the failure consequence. This output documentation is less explicit. Consider either adding "exactly" or cross-referencing the input documentation for the full explanation.
✏️ Proposed clarification
-Each migrator pair requires a unique `label`. Set the same label value on both the input and output within a pair. +Each migrator pair requires a unique `label`. The label must match exactly between the paired input and output components.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@modules/components/pages/outputs/redpanda_migrator.adoc` at line 47, The output docs for Redpanda migrator currently state "Each migrator pair requires a unique `label`" but don't specify that the input and output must match exactly; update the sentence in redpanda_migrator.adoc to explicitly say that the label value must match exactly between the paired input and output (e.g., "Set the same label value on both the input and output within a pair; labels must match exactly"), and optionally add a short cross-reference note pointing readers to the paired input component's documentation for the failure behavior details.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@modules/components/pages/outputs/redpanda_migrator.adoc`:
- Line 47: The output docs for Redpanda migrator currently state "Each migrator
pair requires a unique `label`" but don't specify that the input and output must
match exactly; update the sentence in redpanda_migrator.adoc to explicitly say
that the label value must match exactly between the paired input and output
(e.g., "Set the same label value on both the input and output within a pair;
labels must match exactly"), and optionally add a short cross-reference note
pointing readers to the paired input component's documentation for the failure
behavior details.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0f6285f1-0e2e-4435-8f81-755f02013645
📒 Files selected for processing (1)
modules/components/pages/outputs/redpanda_migrator.adoc
Update the redpanda_migrator output page to document the new sync_topic_interval field (ENG-1051/CON-334): topics now sync from source on startup and every 5 minutes by default, including empty source topics with no message flow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Eliminate passive voice throughout - Fix subject-verb agreement on plural subjects after colons - Use natural subjects as actors where possible (carry over, sync, rewind) - Trim redundant "The migrator" where intro sentence establishes subject - Fix consumer groups default behavior (all non-Dead groups, not only Empty) - Promote bold pseudo-headings to H3 in Synchronization details - Tighten metrics table column widths and remove redundant "metrics" from group headers - Add framing sentence before config tabs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rame retention scenario - Spell out the failure mode for mismatched migrator-pair labels (resolves CodeRabbit nit from 2026-03-20). - Link the prose mention of sync_topic_interval to its field-row anchor so readers can jump to the canonical definition. - Replace the bare engineering claim "Data flows as messages are read from the input" with the more accurate behavior from the migrator source: topics are still created on demand when the first message arrives. Frame the empty-topic scenario with the retention-cleanup use case from ENG-1051. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
6eb7979 to
6135d35
Compare
|
@mmatczuk — picking up this PR from I rebased on
Could you check (a) whether the "How it works > Topics" bullet is technically accurate, and (b) whether anything else from the engineering work needs surfacing in the manual prose that the auto-gen field partial doesn't cover? Thanks. (Also addressing CodeRabbit's COMMENTED review from 2026-03-20 — the label-matching clarification is now applied; rest of the nit was on the original pseudo-heading structure which has since been promoted to H3.) |
|
@copilot resolve the merge conflicts in this pull request |
Resolved in |
Summary
Resolves DOC-2008. Documents the new
sync_topic_intervalfield onredpanda_migratoroutput, which implements the engineering change in ENG-1051 (upstream Connect PR redpanda-data/connect#4059).This PR was originally opened by
@mfernest, who is no longer with the team.@Feediver1is taking it over to finalize.What changed on this page
sync_topic_intervalbehavior: topics sync from source on startup and every 5 minutes by default, including source topics that have no current data (for example, after retention cleanup). Settingsync_topic_interval: 0sdisables the periodic sync; topics are still created on demand when the first message arrives.Emptystate groups migrated" — corrected to "all groups except those inDeadstate migrate by default" withconsumer_groups.only_empty: trueas the opt-in.*Topics*,*Schema Registry*,*Consumer Groups*) under "Synchronization details" to real H3 headings so they're anchorable.sync_topic_intervalnow anchors to its field-row entry in the auto-gen partial.Engineering scope (ENG-1051)
The customer-facing scenario is: source topics emptied by retention cleanup were previously not re-created at the destination because Connect only created topics on first data flow. With
sync_topic_interval, Connect proactively syncs the topic set on a configurable schedule (default 5 minutes) so destination topology matches source even when some source topics are empty. Thesync_topic_intervalfield row is in the auto-generated field partial after the bot's run in PR #428.Preview pages
sync_topic_intervalfield rowTest plan
sync_topic_intervalfield row renders in the configuration field listing with the canonical description, default5m, and three examples<<sync_topic_interval>>in the "How it works" Topics bullet resolves to the field row🤖 Generated with Claude Code