Skip to content

Version 0 testing#45

Merged
reez merged 3 commits into
mainfrom
yo
Oct 8, 2025
Merged

Version 0 testing#45
reez merged 3 commits into
mainfrom
yo

Conversation

@reez
Copy link
Copy Markdown
Owner

@reez reez commented Oct 8, 2025

  • Cancel and track the in-flight NFC read task so a new scan or session invalidation can’t leave a runaway async job touching a stale NFCTagReaderSession.
    • NFC task management mirrors the pattern we’ve been using elsewhere (see 6f206a8) to avoid dead transports
  • Skip card.dump for the active (sealed) SatsCard slot and reuse the status/address data instead; historical slots still get dumped as before, this avoids the panic path that occurs when CKTap omits the pubkey for a sealed slot, which was the root cause of the TestFlight crash reported in Version 0 testing #37.
    • I opened a PR on CKTap to address this fix: return slotsealed when dump omits pubkey bitcoindevkit/rust-cktap#49 so dump returns DumpError::SlotSealed instead of panicking, but this app-side guard keeps current builds stable and keeps us from issuing a doomed dump call even after the library is patched (might as well leave this in even after the library is patched)

@reez reez linked an issue Oct 8, 2025 that may be closed by this pull request
@reez reez mentioned this pull request Oct 8, 2025
@reez reez merged commit a973246 into main Oct 8, 2025
@reez reez deleted the yo branch October 8, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 0 testing

1 participant