feat(ir): ArrayT type, array bounds checking, IsPure fix#58
Merged
Conversation
- Add `ArrayT(EvmBaseType, usize)` variant to EvmType in both Rust and egglog schemas. Storage arrays now display as `[u256; 10]` instead of `u256` in IR output. Updated pretty-printer, sexp serialization, type lowering, codegen type_slot_count, and cost table. - Add array bounds checking during lowering: constant out-of-bounds indices produce compile-time errors with source spans; non-constant indices emit runtime LT + REVERT guards for both memory-backed and storage-backed arrays. - Fix pre-existing bug in dead_code.egg IsPure rule for If nodes: the rule only checked 3 of 4 arguments (pred, inputs, then) but skipped the else branch. This caused If nodes with Revert in the else branch to be incorrectly marked pure and eliminated by DCE. - Add 18 EVM execution tests covering element access, mutation, loop iteration, slices, storage round-trips, OOB reverts, and boundary indices, all verified at O0/O1/O2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
refcell
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayT(EvmBaseType, usize)variant toEvmTypeacross the full pipeline (schema.egg, schema.rs, sexp, pretty-printer, costs, codegen) so array type information is preserved in IR instead of falling back tou256If(LT(idx, len), Empty, Revert)guards for dynamic indices — covers both memory and storage arraysdead_code.eggwhereIsPurerule forIfnodes only checked 3 of 4 arguments, causing bounds checks (and otherIfnodes with side-effecting else branches) to be incorrectly eliminated at O1+Test plan
crates/evm-tests/tests/suites/arrays.rscovering memory arrays (element access, read-all, write-then-read, iteration, find-max), storage arrays (set/get, multi-slot, sum, overwrite), OOB reverts (storage get/set, large index), boundary indices, and smaller storage arrays🤖 Generated with Claude Code