Skip to content

Commit c9f64be

Browse files
Copilotfregante
andcommitted
Fix ESM workflow: revert download-artifact from v7 to v4
The v7 version of download-artifact has a breaking change where it creates an extra directory level (artifact/artifact/package.json instead of artifact/package.json). Reverting to v4 fixes this issue. Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
1 parent 727ab91 commit c9f64be

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

.github/workflows/esm-lint.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ jobs:
3030
runs-on: ubuntu-latest
3131
needs: Pack
3232
steps:
33-
- uses: actions/download-artifact@v7
33+
- uses: actions/download-artifact@v4
3434
- run: npx publint ./artifact
3535
Webpack:
3636
runs-on: ubuntu-latest
3737
needs: Pack
3838
steps:
39-
- uses: actions/download-artifact@v7
39+
- uses: actions/download-artifact@v4
4040
- run: npm install --omit=dev ./artifact
4141
- run: echo "$IMPORT_STATEMENT" > index.js
4242
- run: webpack --entry ./index.js
@@ -45,7 +45,7 @@ jobs:
4545
runs-on: ubuntu-latest
4646
needs: Pack
4747
steps:
48-
- uses: actions/download-artifact@v7
48+
- uses: actions/download-artifact@v4
4949
- run: npm install --omit=dev ./artifact
5050
- run: echo "$IMPORT_STATEMENT" > index.js
5151
- run: >
@@ -57,15 +57,15 @@ jobs:
5757
runs-on: ubuntu-latest
5858
needs: Pack
5959
steps:
60-
- uses: actions/download-artifact@v7
60+
- uses: actions/download-artifact@v4
6161
- run: npm install --omit=dev ./artifact rollup@4 @rollup/plugin-json @rollup/plugin-node-resolve
6262
- run: echo "$IMPORT_STATEMENT" > index.js
6363
- run: npx rollup -p node-resolve -p @rollup/plugin-json index.js
6464
Vite:
6565
runs-on: ubuntu-latest
6666
needs: Pack
6767
steps:
68-
- uses: actions/download-artifact@v7
68+
- uses: actions/download-artifact@v4
6969
- run: npm install --omit=dev ./artifact
7070
- run: echo '<script type="module">$IMPORT_STATEMENT</script>' > index.html
7171
- run: npx vite build
@@ -74,7 +74,7 @@ jobs:
7474
runs-on: ubuntu-latest
7575
needs: Pack
7676
steps:
77-
- uses: actions/download-artifact@v7
77+
- uses: actions/download-artifact@v4
7878
- run: echo '{}' > package.json
7979
- run: echo "$IMPORT_STATEMENT" > index.js
8080
- run: npm install --omit=dev ./artifact
@@ -83,7 +83,7 @@ jobs:
8383
runs-on: ubuntu-latest
8484
needs: Pack
8585
steps:
86-
- uses: actions/download-artifact@v7
86+
- uses: actions/download-artifact@v4
8787
- run: echo '{"type":"module"}' > package.json
8888
- run: npm install --omit=dev ./artifact @sindresorhus/tsconfig
8989
- run: echo "$IMPORT_STATEMENT" > index.ts
@@ -96,7 +96,7 @@ jobs:
9696
runs-on: ubuntu-latest
9797
needs: Pack
9898
steps:
99-
- uses: actions/download-artifact@v7
99+
- uses: actions/download-artifact@v4
100100
- uses: actions/setup-node@v6
101101
with:
102102
node-version-file: artifact/package.json

0 commit comments

Comments
 (0)