Skip to content

fix(mui): themedtitle sidebar title#7244

Closed
harsha-cpp wants to merge 3 commits into
refinedev:mainfrom
harsha-cpp:fix/themedtitle-sidebar-title
Closed

fix(mui): themedtitle sidebar title#7244
harsha-cpp wants to merge 3 commits into
refinedev:mainfrom
harsha-cpp:fix/themedtitle-sidebar-title

Conversation

@harsha-cpp

@harsha-cpp harsha-cpp commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Related issue(s) linked
  • Tests for the changes have been added
  • Changesets have been added

What is the current behavior?

ThemedSider doesn’t consistently honor the Title override. When Title is provided as a render prop or element, the default title may still render.

What is the new behavior?

If Title is provided, it is always rendered (supports component, render prop, or element) and the default title is only used when no override is provided.

Fixes (issue)

Fixes #7239

@harsha-cpp harsha-cpp requested a review from a team as a code owner February 3, 2026 08:11
@changeset-bot

changeset-bot Bot commented Feb 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4ddbff4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@refinedev/mui Major
@refinedev/inferencer Major
@refinedev/live-previews Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BatuhanW BatuhanW changed the title Fix/themedtitle sidebar title fix(mui): themedtitle sidebar title Feb 12, 2026
@alicanerdurmaz

Copy link
Copy Markdown
Collaborator

Hey @harsha-cpp, thanks for the PR!

The Title prop is typed as React.FC, so it only accepts function components. The existing code const RenderToTitle = TitleFromProps ?? DefaultTitle already handles this correctly — if Title is provided it's used, otherwise the default kicks in. The isValidElement / ReactNode branches in renderTitle handle cases the type system doesn't even allow.

Also, the changeset is marked as major but there's no breaking change here. I wasn't able to reproduce #7239 either. Closing this one — thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ThemedTitle is not working

2 participants