Update index.tsx#7293
Closed
raymondoyondi wants to merge 1 commit into
Closed
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(core): pass meta params to useButtonCanAccess in useDeleteButton (#7289)
This PR addresses the issue where useDeleteButton accepts a meta property but fails to forward it to the useButtonCanAccess hook. This prevents custom Access Control Providers from receiving necessary metadata when determining delete permissions.
Related Issues
Changes
How to test?
Create a custom accessControlProvider that logs the params of the can method.
Use a DeleteButton (or the useDeleteButton hook) and pass a unique meta object: <DeleteButton meta={{ foo: "bar" }} />.
Observe that without this fix, the meta property is undefined in the access control check; with this fix, it correctly contains { foo: "bar" }.