feat(mui): add filters.syncFilterModel option to useDataGrid#7420
Closed
jwgmeligmeyling wants to merge 1 commit into
Closed
feat(mui): add filters.syncFilterModel option to useDataGrid#7420jwgmeligmeyling wants to merge 1 commit into
jwgmeligmeyling wants to merge 1 commit into
Conversation
useDataGrid controls dataGridProps.filterModel from an internal muiCrudFilters state that is only updated by the DataGrid's own filter panel and by search(). Calls to the returned setFilters (or filter changes synced from the URL via syncWithLocation) updated filters but left filterModel stale, so apps driving filters from external UIs could not reflect their state in the grid. Add an opt-in filters.syncFilterModel flag. When true, a useEffect mirrors filters into muiCrudFilters via isEqual guard, so external mutations land in filterModel without a no-op re-render on the debounced internal path. The default is false to preserve the behavior agreed on in the original bug report, where unconditional syncing was rejected because it can clobber in-progress column-header edits in apps that mix DataGrid filter inputs and external setFilters calls. Refs: refinedev#5860 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 109e840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useDataGrid controls dataGridProps.filterModel from an internal muiCrudFilters state that is only updated by the DataGrid's own filter panel and by search(). Calls to the returned setFilters (or filter changes synced from the URL via syncWithLocation) updated filters but left filterModel stale, so apps driving filters from external UIs could not reflect their state in the grid.
Add an opt-in filters.syncFilterModel flag. When true, a useEffect mirrors filters into muiCrudFilters via isEqual guard, so external mutations land in filterModel without a no-op re-render on the debounced internal path. The default is false to preserve the behavior agreed on in the original bug report, where unconditional syncing was rejected because it can clobber in-progress column-header edits in apps that mix DataGrid filter inputs and external setFilters calls.
Refs: #5860
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes (issue)
Notes for reviewers