fix(mui): stabilize useDataGrid filterModel identity#7423
Open
jwgmeligmeyling wants to merge 1 commit into
Open
fix(mui): stabilize useDataGrid filterModel identity#7423jwgmeligmeyling wants to merge 1 commit into
jwgmeligmeyling wants to merge 1 commit into
Conversation
useDataGrid returned dataGridProps.filterModel as a freshly-allocated object on every render, even when the underlying filter state was unchanged. Consumers feeding it into MUI X DataGrid or to useEffect deps keyed on its identity hit unnecessary work and could trigger effect loops in user code. Wrap the filterModel computation in useMemo keyed on muiCrudFilters, the permanent filters, and the column-type map — mirroring the existing memoization already used for sortModel a few lines above. The column- type map is still tracked via the same useRef as before; including columnsTypes.current in the deps array means the next render after onStateChange reassigns the ref picks up the change, matching the previous per-render computation. Behavior is otherwise unchanged: the value still updates whenever the underlying filter state — or the DataGrid-reported column types — actually changes.
🦋 Changeset detectedLatest commit: d576310 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useDataGrid returned dataGridProps.filterModel as a freshly-allocated object on every render, even when the underlying filter state was unchanged. Consumers feeding it into MUI X DataGrid or to useEffect deps keyed on its identity hit unnecessary work and could trigger effect loops in user code.
Wrap the filterModel computation in useMemo keyed on muiCrudFilters, the permanent filters, and the column-type map — mirroring the existing memoization already used for sortModel a few lines above. The column- type map is still tracked via the same useRef as before; including columnsTypes.current in the deps array means the next render after onStateChange reassigns the ref picks up the change, matching the previous per-render computation.
Behavior is otherwise unchanged: the value still updates whenever the underlying filter state — or the DataGrid-reported column types — actually changes.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes (issue)
Notes for reviewers