fix(mui): clear stale filter value on DataGrid filter row field swap#7424
Open
jwgmeligmeyling wants to merge 1 commit into
Open
fix(mui): clear stale filter value on DataGrid filter row field swap#7424jwgmeligmeyling wants to merge 1 commit into
jwgmeligmeyling wants to merge 1 commit into
Conversation
When a user changed the column on an existing filter row in the MUI X DataGrid filter panel, MUI carried over the previous value to the new field. `useDataGrid` forwarded that value to the data provider as a CrudFilter, producing nonsensical queries for fields whose value space differs (enums, foreign-key references, booleans, etc.). `onFilterModelChange` now keeps a ref to the previous filter model and, when the item count is unchanged, clears `value` on any row whose `field` changed. Items are matched by `GridFilterItem.id` (falling back to position when an id is absent) so reorders and single-step swap operations — e.g. delete + add in one model update — aren't misread as field changes. The cached previous model is also reset in `search()`, which replaces filters out-of-band and would otherwise leave a stale baseline that wipes the next user value edit. The caller's model is not mutated.
🦋 Changeset detectedLatest commit: 39dca76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user changed the column on an existing filter row in the MUI X DataGrid filter panel, MUI carried over the previous value to the new field.
useDataGridforwarded that value to the data provider as a CrudFilter, producing nonsensical queries for fields whose value space differs (enums, foreign-key references, booleans, etc.).onFilterModelChangenow keeps a ref to the previous filter model and, when the item count is unchanged, clearsvalueon any row whosefieldchanged. Items are matched byGridFilterItem.id(falling back to position when an id is absent) so reorders and single-step swap operations — e.g. delete + add in one model update — aren't misread as field changes. The cached previous model is also reset insearch(), which replaces filters out-of-band and would otherwise leave a stale baseline that wipes the next user value edit. The caller's model is not mutated.PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The value for the old filter is preserved when switching fields, causing issues, particularly when switching fields that have different types (i.e. text input to date input).
What is the new behavior?
Value is cleared.
fixes (issue)
Notes for reviewers