fix(core): keep query context signal lazy when merging meta#7426
Open
jwgmeligmeyling wants to merge 1 commit into
Open
fix(core): keep query context signal lazy when merging meta#7426jwgmeligmeyling wants to merge 1 commit into
jwgmeligmeyling wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d848100 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jwgmeligmeyling
changed the title
jwgmeligmeyling
force-pushed
the
fix/lazy-query-context-signal
branch
from
7ecac9c to
d848100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps
queryContext.signallazy when merging query context intometa.Previously we spread
prepareQueryContext(context)into a newmetaobject inside multiple core data hooks. Becausesignalis defined as a getter, object spread eagerly accessed it during merge. That marks the query as abortable earlier than intended and can trigger the duplicate request behavior described in #7132.Closes #7132.
Changes
prepareQueryContextto accept an optionalmetaobject and merge into it internallysignalas a lazy getter on the returned objectuseListuseOneuseManyuseInfiniteListuseCustomsignalaccessValidation
corepack pnpm --filter @refinedev/devtools-shared --filter @refinedev/devtools-internal buildcorepack pnpm --dir packages/core test -- src/definitions/helpers/prepare-query-context/index.spec.ts src/hooks/data/useList.spec.tsx src/hooks/data/useOne.spec.tsx src/hooks/data/useMany.spec.tsx src/hooks/data/useCustom.spec.tsx src/hooks/data/useInfiniteList.spec.tsxcorepack pnpm --dir packages/core build