fix(examples): handle OAuth access_denied in auth-headless example#7437
Open
SpencerJung wants to merge 1 commit into
Open
fix(examples): handle OAuth access_denied in auth-headless example#7437SpencerJung wants to merge 1 commit into
SpencerJung wants to merge 1 commit into
Conversation
When a user cancels GitHub OAuth login, the callback URL contains error=access_denied. The authProvider's check method now detects this and returns a user-friendly error message instead of a generic 401 Unauthorized response. Closes refinedev#7407
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(examples): handle OAuth access_denied in auth-headless example
Description
When a user cancels GitHub OAuth login by clicking "Cancel" on the GitHub authorization screen, the callback URL contains
error=access_denied. Previously, the authProvider did not handle this case, resulting in a generic "No user information from OAuth provider" 401 Unauthorized error.This PR adds handling for the
access_deniederror in the auth-headless example's authProvider check method. Now when a user cancels OAuth, they see a friendly error message: "Login cancelled by user" / "Authorization denied".Changes
examples/auth-headless/src/App.tsxauthProvider.check()error=access_deniedis detected in URLTesting
Related Issue
Closes #7407