Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/get-default-filter-falsy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@refinedev/core": patch
---

fix(core): preserve falsy values in `getDefaultFilter`

`getDefaultFilter` used `filter.value || []`, which replaced valid falsy filter values (`0`, `false`, `""`) with an empty array. As a result, default values for numeric/boolean/empty-string filters were lost when populating form controls. Switched to `filter.value ?? []` so only `undefined`/`null` fall back to `[]`.
16 changes: 16 additions & 0 deletions packages/core/src/definitions/table/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,22 @@ describe("definitions/table", () => {
expect(getDefaultFilter("title", filters)).toEqual("test");
});

it("getDefaultFilter preserves falsy values", () => {
expect(
getDefaultFilter("status", [
{ field: "status", operator: "eq", value: 0 },
]),
).toEqual(0);
expect(
getDefaultFilter("active", [
{ field: "active", operator: "eq", value: false },
]),
).toEqual(false);
expect(
getDefaultFilter("name", [{ field: "name", operator: "eq", value: "" }]),
).toEqual("");
});

it("stringify table params correctly", async () => {
const pagination = {
currentPage: 1,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/definitions/table/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export const getDefaultFilter = (
});

if (filter) {
return filter.value || [];
return filter.value ?? [];
}

return undefined;
Expand Down