Allow BaseKey to be an array of numbers#7478
Open
777yash77 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 7128628 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
`BaseKey` now supports `number[]` identifiers for compatibility with generated API models that represent identifiers as arrays of numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
BaseKeyonly supportsstringandnumberidentifiers. Generated API models that represent identifiers asnumber[]are not compatible with theBaseKeytype without explicit type casting.What is the new behavior?
BaseKeynow supportsnumber[]identifiers in addition tostringandnumber.This improves compatibility with generated API models that represent identifiers as arrays of numbers.
Fixes #7403
Notes for reviewers
This change extends the existing
BaseKeyunion type to supportnumber[]identifiers as requested in #7403.