fix(react-hook-form): replace custom layout effect sync with native reset#7479
Open
hiteshchoudhary738-alt wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: baa54bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
During SPA navigation,
useFieldArrayinstances wrapped within components conditional onformLoadingfail to retain values upon form remounting. This occurs because the internal microtask-deferredapplyValuesToFieldsexecutes and checksgetRegisteredFields()before the dynamically rendering inputs finish their mount-level registration lifecycle with React Hook Form.What is the new behavior?
Replaced the custom microtask
applyValuesToFieldsframework on initial data load with React Hook Form's nativereset(data, { keepDirtyValues: true }). This natively handles delayed field hydration irrespective of active DOM input registration states, ensuring complete value restoration when revisiting the edit view.fixes #7401
Notes for reviewers
The existing downstream render-driven loop for late-registered inputs (
useEffectcheckinggetMountedFields()) remains intact to preserve structural sync for components like unmounted UI controllers without regressing state on dirty fields.