Skip to content

Commit 89c9646

Browse files
committed
fix the tests and only install chrome
1 parent e9d341b commit 89c9646

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

.github/workflows/app_harness.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
working-directory: ${{ matrix.example }}
5858
run: |
5959
source venv/bin/activate
60-
playwright install --with-deps
60+
playwright install chromium --with-deps
6161
- name: Initialize Reflex App
6262
working-directory: ${{ matrix.example }}
6363
run: |

form-designer/tests/test_create_form.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ def test_create_form(
2222
# Check that the frontend URL is set
2323
assert form_designer_app.frontend_url is not None
2424

25-
def _url(url):
25+
def _url(url: str):
26+
url = url.removeprefix("/")
27+
assert form_designer_app.frontend_url is not None
2628
return re.compile(form_designer_app.frontend_url + url)
2729

2830
page.goto(form_designer_app.frontend_url)
@@ -118,7 +120,7 @@ def _url(url):
118120

119121
# Try to check responses for the form
120122
form_id = form_fill_url.strip("/").rpartition("/")[2]
121-
responses_url = f"/responses/{form_id}/"
123+
responses_url = f"responses/{form_id}/"
122124
page.goto(form_designer_app.frontend_url + responses_url)
123125
expect(page).to_have_url(_url("/login/"))
124126

form-designer/tests/test_login.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,14 @@ def test_create_user(
3232
):
3333
assert form_designer_app.frontend_url is not None
3434

35-
def _url(url):
35+
def _url(url: str):
36+
url = url.removeprefix("/")
37+
assert form_designer_app.frontend_url is not None
3638
return re.compile(form_designer_app.frontend_url + url)
3739

3840
page.goto(form_designer_app.frontend_url)
3941
page.set_default_timeout(2500)
40-
expect(page).to_have_url(form_designer_app.frontend_url + "/")
42+
expect(page).to_have_url(form_designer_app.frontend_url)
4143

4244
page.locator(".lucide-menu").click()
4345
page.get_by_role("menuitem", name="Register").click()
@@ -83,7 +85,7 @@ def _url(url):
8385
expect(page.get_by_text(TEST_USER)).not_to_be_visible()
8486

8587
# Should not be able to re-register as the same user
86-
page.goto(form_designer_app.frontend_url + "/register/")
88+
page.goto(form_designer_app.frontend_url + "register/")
8789
page.get_by_placeholder("Username").fill(TEST_USER)
8890
page.get_by_placeholder("Password", exact=True).fill(TEST_PASSWORD)
8991
page.get_by_placeholder("Confirm Password").fill(TEST_PASSWORD)

0 commit comments

Comments
 (0)