Skip to content

Commit ac430fa

Browse files
committed
form-designer: Update form id handling
1 parent d4b41dd commit ac430fa

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

form-designer/form_designer/components/form_editor.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,16 @@ def set_name(self, name: str):
4242
if not self._user_has_access():
4343
return
4444
with rx.session() as session:
45-
self.form.name = name
46-
session.add(self.form)
45+
if self.form.id is not None:
46+
form = session.get(Form, self.form.id)
47+
else:
48+
form = self.form
49+
form.name = name
50+
session.add(form)
4751
session.commit()
48-
session.refresh(self.form)
4952
yield FormSelectState.load_forms
50-
if self.form.id > 0:
51-
return rx.redirect(routes.edit_form(self.form.id))
53+
if form.id is not None and form.id > 0:
54+
return rx.redirect(routes.edit_form(form.id))
5255

5356
def update_field(self, field: Field):
5457
if not self._user_has_access():

form-designer/form_designer/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ class Response(rx.Model, table=True):
8080
server_default=sqlmodel.func.now(),
8181
),
8282
)
83+
hidden: bool = False
8384
form: Form = sqlmodel.Relationship(back_populates="responses")
8485

8586
field_values: list[FieldValue] = sqlmodel.Relationship(

form-designer/form_designer/pages/response.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def response(r: Response):
6060
rx.icon(tag="x", size=16),
6161
color_scheme="tomato",
6262
margin_right="1em",
63-
on_click=ResponsesState.delete_response(r.id),
63+
on_click=ResponsesState.delete_response(r.id).stop_propagation,
6464
),
6565
content="Delete this Response",
6666
),

0 commit comments

Comments
 (0)