Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

[ENG-5373] site navigation#1262

Merged
Alek99 merged 7 commits intomainfrom
ahmad/refactor-nav-links
Apr 8, 2025
Merged

[ENG-5373] site navigation#1262
Alek99 merged 7 commits intomainfrom
ahmad/refactor-nav-links

Conversation

@LineIndent
Copy link
Copy Markdown
Contributor

No description provided.

@LineIndent LineIndent marked this pull request as ready for review April 4, 2025 11:03
@LineIndent LineIndent marked this pull request as draft April 4, 2025 11:12
@LineIndent LineIndent marked this pull request as ready for review April 4, 2025 13:13
@LineIndent LineIndent changed the title wip site navigation [ENG-5373] site navigation Apr 4, 2025
@linear
Copy link
Copy Markdown

linear Bot commented Apr 4, 2025

Copy link
Copy Markdown
Member

@Alek99 Alek99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to be missing the cloud docs we need to go through all the changes and make sure we are not using pages in the refactor

Comment thread pcweb/pages/docs/cloud_cliref.py Outdated
docs = generate_docs(module_value)
title = module_name.replace("_", " ").title()
page_data = docpage(f"/docs/hosting/{module_name}/", title)(docs)
page_data = docpage(f"/cloud/{module_name}/", title)(docs)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still should be under docs all the doc pages should be under /docs/

Copy link
Copy Markdown
Member

@Alek99 Alek99 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having under hosting is fine we dont have to change it to cloud

@Alek99 Alek99 self-requested a review April 8, 2025 17:53
@Alek99 Alek99 merged commit ac1b985 into main Apr 8, 2025
9 checks passed
@Alek99 Alek99 deleted the ahmad/refactor-nav-links branch April 8, 2025 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants