Skip to content

ENG-8415: Add uses cases and templates link to landing#1696

Merged
tgberkeley merged 1 commit intomainfrom
carlos/add-use-cases-button
Dec 1, 2025
Merged

ENG-8415: Add uses cases and templates link to landing#1696
tgberkeley merged 1 commit intomainfrom
carlos/add-use-cases-button

Conversation

@carlosabadia
Copy link
Copy Markdown
Collaborator

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Nov 26, 2025

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Nov 26, 2025

Greptile Overview

Greptile Summary

This PR adds navigation links to use cases and templates on the landing page and refactors integration display components for better code reuse.

Key Changes

  • Added bottom_links() component to landing page with navigation to /use-cases and /templates
  • Refactored integration_image() in gallery.py to accept optional class_name parameter and removed tooltip wrapper
  • Created reusable integrations_stack() function in gallery.py for consistent integration display across pages
  • Updated apps.py to use shared integrations_stack() instead of inline implementation
  • Replaced UI tooltip components with native HTML title attributes for simpler implementation
  • Improved styling consistency for integration displays with stacked avatar layout

Issues Found

  • The unused integration_image() function in apps.py (lines 24-43) should be removed per code quality guidelines

Confidence Score: 4/5

  • This PR is safe to merge with minor cleanup recommended
  • The changes are well-structured and improve code reusability. The refactoring consolidates duplicate logic into shared functions. The only issue is an unused function in apps.py that should be removed to maintain code cleanliness
  • Pay attention to pcweb/pages/gallery/apps.py - remove the unused integration_image function before merging

Important Files Changed

File Analysis

Filename Score Overview
pcweb/pages/gallery/apps.py 4/5 Refactored to use shared integrations_stack function, but contains unused integration_image function that should be removed
pcweb/pages/gallery/gallery.py 5/5 Refactored integration_image and added integrations_stack function for reusable integration display with native HTML tooltips
pcweb/pages/landing/views/use_cases.py 5/5 Added bottom_links component with navigation to use cases and templates pages, improved overflow styling

Sequence Diagram

sequenceDiagram
    participant User
    participant LandingPage as Landing Page (use_cases.py)
    participant GalleryPage as Gallery Page (gallery.py)
    participant AppsPage as Apps Page (apps.py)
    
    User->>LandingPage: View use cases section
    LandingPage->>LandingPage: Render bottom_links()
    LandingPage->>GalleryPage: Link to /templates
    
    User->>GalleryPage: Navigate to templates
    GalleryPage->>GalleryPage: Render integrations_stack()
    GalleryPage->>GalleryPage: Call integration_image() for each integration
    
    User->>AppsPage: Navigate to specific app/template
    AppsPage->>GalleryPage: Import integrations_stack()
    AppsPage->>GalleryPage: Render integrations in metadata
    GalleryPage->>GalleryPage: Display stacked integration avatars
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. pcweb/pages/gallery/apps.py, line 24-43 (link)

    style: unused function should be removed

    Context Used: Rule from dashboard - Remove commented-out code before merging PRs. (source)

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@tgberkeley tgberkeley merged commit 23bf974 into main Dec 1, 2025
10 checks passed
@tgberkeley tgberkeley deleted the carlos/add-use-cases-button branch December 1, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants