Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pcweb/pages/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from .affiliates import affiliates as affiliates
from .blog import blog_routes
from .booked import booked as booked
from .check_your_email_demo import page_thank_you as page_thank_you
from .customers.data.customers import customers_routes
from .customers.landing import customers as customers
from .databricks.databricks import databricks_page as databricks_page
Expand All @@ -15,6 +16,9 @@
from .gallery.apps import gallery_apps_routes
from .hosting.hosting import hosting_landing as hosting_landing
from .landing.landing import landing as landing
from .meeting_successfully_booked import (
page_meeting_successfully_booked as page_meeting_successfully_booked,
)
Comment on lines +19 to +21
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import uses parentheses for a single import, which is inconsistent with the rest of the file's import style. All other single imports in this file use the format from .module import name as name without parentheses.

Suggested change
from .meeting_successfully_booked import (
page_meeting_successfully_booked as page_meeting_successfully_booked,
)
from .meeting_successfully_booked import page_meeting_successfully_booked as page_meeting_successfully_booked

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/__init__.py
Line: 19:21

Comment:
The import uses parentheses for a single import, which is inconsistent with the rest of the file's import style. All other single imports in this file use the format `from .module import name as name` without parentheses.

```suggestion
from .meeting_successfully_booked import page_meeting_successfully_booked as page_meeting_successfully_booked
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

from .page404 import page404 as page404
from .pricing.pricing import pricing as pricing
from .sales import sales as sales
Expand Down
22 changes: 22 additions & 0 deletions pcweb/pages/check_your_email_demo.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import reflex as rx

from pcweb.flexdown import markdown_with_shiki
from pcweb.templates.webpage import webpage

contents = """
# Thanks for Submitting a Demo Request

Check your email, we sent a calendar link to get access.
Comment on lines +6 to +9
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading "Thanks for Submitting a Demo Request" doesn't match the context of the page. The message talks about checking email for a calendar link, which suggests this is for after someone submits a demo request form, but the heading is generic. Consider making the heading more specific to match the message content, or vice versa.

Additionally, this page lacks navigation options. Similar success pages like booked.py and to_be_booked.py provide "Home" and "Installation" buttons to guide users on their next steps. This page leaves users stranded with no clear path forward.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/check_your_email_demo.py
Line: 6:9

Comment:
The heading "Thanks for Submitting a Demo Request" doesn't match the context of the page. The message talks about checking email for a calendar link, which suggests this is for after someone submits a demo request form, but the heading is generic. Consider making the heading more specific to match the message content, or vice versa.

Additionally, this page lacks navigation options. Similar success pages like `booked.py` and `to_be_booked.py` provide "Home" and "Installation" buttons to guide users on their next steps. This page leaves users stranded with no clear path forward.

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

"""


@webpage(
path="/thank-you",
title="Thanks for Submitting a Demo Request · Reflex.dev",
add_as_page=False,
)
def page_thank_you():
return rx.box(
markdown_with_shiki(contents),
class_name="h-[80vh] w-full flex flex-col items-center justify-center",
)
22 changes: 22 additions & 0 deletions pcweb/pages/meeting_successfully_booked.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import reflex as rx

from pcweb.flexdown import markdown_with_shiki
from pcweb.templates.webpage import webpage

contents = """
# Thanks for Submitting a Demo Request

Meeting successfully booked!
Comment on lines +6 to +9
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading "Thanks for Submitting a Demo Request" contradicts the body message "Meeting successfully booked!" These two messages convey different meanings - one thanks for submission while the other confirms booking completion. The heading should match the actual state being communicated.

Additionally, this page lacks navigation options. Similar success pages like booked.py and to_be_booked.py provide "Home" and "Installation" buttons to guide users on their next steps. Users landing on this page after booking a meeting have no clear way to continue their journey.

Prompt To Fix With AI
This is a comment left during a code review.
Path: pcweb/pages/meeting_successfully_booked.py
Line: 6:9

Comment:
The heading "Thanks for Submitting a Demo Request" contradicts the body message "Meeting successfully booked!" These two messages convey different meanings - one thanks for submission while the other confirms booking completion. The heading should match the actual state being communicated.

Additionally, this page lacks navigation options. Similar success pages like `booked.py` and `to_be_booked.py` provide "Home" and "Installation" buttons to guide users on their next steps. Users landing on this page after booking a meeting have no clear way to continue their journey.

How can I resolve this? If you propose a fix, please make it concise.

"""


@webpage(
path="/meeting-successfully-booked",
title="Meeting Successfully Booked · Reflex.dev",
add_as_page=False,
)
def page_meeting_successfully_booked():
return rx.box(
markdown_with_shiki(contents),
class_name="h-[80vh] w-full flex flex-col items-center justify-center",
)
Loading