-
Notifications
You must be signed in to change notification settings - Fork 230
add thank you and meeting success pages #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import reflex as rx | ||
|
|
||
| from pcweb.flexdown import markdown_with_shiki | ||
| from pcweb.templates.webpage import webpage | ||
|
|
||
| contents = """ | ||
| # Thanks for Submitting a Demo Request | ||
|
|
||
| Check your email, we sent a calendar link to get access. | ||
|
Comment on lines
+6
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The heading "Thanks for Submitting a Demo Request" doesn't match the context of the page. The message talks about checking email for a calendar link, which suggests this is for after someone submits a demo request form, but the heading is generic. Consider making the heading more specific to match the message content, or vice versa. Additionally, this page lacks navigation options. Similar success pages like Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: pcweb/pages/check_your_email_demo.py
Line: 6:9
Comment:
The heading "Thanks for Submitting a Demo Request" doesn't match the context of the page. The message talks about checking email for a calendar link, which suggests this is for after someone submits a demo request form, but the heading is generic. Consider making the heading more specific to match the message content, or vice versa.
Additionally, this page lacks navigation options. Similar success pages like `booked.py` and `to_be_booked.py` provide "Home" and "Installation" buttons to guide users on their next steps. This page leaves users stranded with no clear path forward.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
||
| """ | ||
|
|
||
|
|
||
| @webpage( | ||
| path="/thank-you", | ||
| title="Thanks for Submitting a Demo Request · Reflex.dev", | ||
| add_as_page=False, | ||
| ) | ||
| def page_thank_you(): | ||
| return rx.box( | ||
| markdown_with_shiki(contents), | ||
| class_name="h-[80vh] w-full flex flex-col items-center justify-center", | ||
| ) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import reflex as rx | ||
|
|
||
| from pcweb.flexdown import markdown_with_shiki | ||
| from pcweb.templates.webpage import webpage | ||
|
|
||
| contents = """ | ||
| # Thanks for Submitting a Demo Request | ||
|
|
||
| Meeting successfully booked! | ||
|
Comment on lines
+6
to
+9
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The heading "Thanks for Submitting a Demo Request" contradicts the body message "Meeting successfully booked!" These two messages convey different meanings - one thanks for submission while the other confirms booking completion. The heading should match the actual state being communicated. Additionally, this page lacks navigation options. Similar success pages like Prompt To Fix With AIThis is a comment left during a code review.
Path: pcweb/pages/meeting_successfully_booked.py
Line: 6:9
Comment:
The heading "Thanks for Submitting a Demo Request" contradicts the body message "Meeting successfully booked!" These two messages convey different meanings - one thanks for submission while the other confirms booking completion. The heading should match the actual state being communicated.
Additionally, this page lacks navigation options. Similar success pages like `booked.py` and `to_be_booked.py` provide "Home" and "Installation" buttons to guide users on their next steps. Users landing on this page after booking a meeting have no clear way to continue their journey.
How can I resolve this? If you propose a fix, please make it concise. |
||
| """ | ||
|
|
||
|
|
||
| @webpage( | ||
| path="/meeting-successfully-booked", | ||
| title="Meeting Successfully Booked · Reflex.dev", | ||
| add_as_page=False, | ||
| ) | ||
| def page_meeting_successfully_booked(): | ||
| return rx.box( | ||
| markdown_with_shiki(contents), | ||
| class_name="h-[80vh] w-full flex flex-col items-center justify-center", | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import uses parentheses for a single import, which is inconsistent with the rest of the file's import style. All other single imports in this file use the format
from .module import name as namewithout parentheses.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI