Fix missing success pages and improve UI #1719
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,27 @@ | ||
| import reflex as rx | ||
| import reflex_ui as ui | ||
|
|
||
| from pcweb.templates.webpage import webpage | ||
|
|
||
|
|
||
| @webpage( | ||
| path="/thank-you", | ||
| title="Thanks for Submitting a Demo Request · Reflex.dev", | ||
| add_as_page=True, | ||
| ) | ||
| def page_thank_you(): | ||
| return rx.box( | ||
| rx.heading( | ||
| "Thanks for Submitting a Demo Request", | ||
| class_name="gradient-heading font-x-large lg:font-xxx-large text-center text-transparent", | ||
| ), | ||
| rx.text( | ||
| "Check your email, we sent a calendar link to get access.", | ||
| class_name="font-md text-balance text-slate-9 text-center mt-4", | ||
| ), | ||
| rx.box( | ||
| ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")), | ||
| class_name="flex flex-row items-center gap-x-4 mt-8", | ||
| ), | ||
| class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4", | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,22 +1,27 @@ | ||||||||||||||
| import reflex as rx | ||||||||||||||
| import reflex_ui as ui | ||||||||||||||
|
|
||||||||||||||
| from pcweb.templates.webpage import webpage | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| @webpage( | ||||||||||||||
| path="/meeting-successfully-booked", | ||||||||||||||
| title="Meeting Successfully Booked · Reflex.dev", | ||||||||||||||
| add_as_page=True, | ||||||||||||||
| ) | ||||||||||||||
| def page_meeting_successfully_booked(): | ||||||||||||||
| return rx.box( | ||||||||||||||
| rx.heading( | ||||||||||||||
| "Meeting Successfully Booked!", | ||||||||||||||
| class_name="gradient-heading font-x-large lg:font-xxx-large text-center text-transparent", | ||||||||||||||
| ), | ||||||||||||||
| rx.text( | ||||||||||||||
| "We have sent you a confirmation email with all the details.", | ||||||||||||||
| class_name="font-md text-balance text-slate-9 text-center mt-4", | ||||||||||||||
| ), | ||||||||||||||
| rx.box( | ||||||||||||||
| ui.button("Home", variant="primary", size="lg", on_click=rx.redirect("/")), | ||||||||||||||
| class_name="flex flex-row items-center gap-x-4 mt-8", | ||||||||||||||
| ), | ||||||||||||||
| class_name="h-[60vh] w-full flex flex-col items-center justify-center p-4", | ||||||||||||||
|
Comment on lines
+22
to
+26
Contributor
There was a problem hiding this comment. The Consider removing
Suggested change
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: pcweb/pages/meeting_successfully_booked.py
Line: 21:25
Comment:
The `gap-x-4` class in the wrapper box is unnecessary since there's only one button. The `gap-x-4` utility adds horizontal spacing between flex items, but with a single child element, this has no effect.
Consider removing `gap-x-4` from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like `/booked` and `/to-be-booked`), then the gap class would be appropriate.
```suggestion
class_name="flex flex-row items-center mt-8",
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||
| ) | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
gap-x-4class in the wrapper box is unnecessary since there's only one button. Thegap-x-4utility adds horizontal spacing between flex items, but with a single child element, this has no effect.Consider removing
gap-x-4from the class name, or if you plan to add a second button (like "Installation" as seen in similar pages like/bookedand/to-be-booked), then the gap class would be appropriate.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI