Skip to content

doc page touch ups#1802

Merged
Alek99 merged 2 commits intomainfrom
doc-page-touch-ups
Apr 1, 2026
Merged

doc page touch ups#1802
Alek99 merged 2 commits intomainfrom
doc-page-touch-ups

Conversation

@Alek99
Copy link
Copy Markdown
Member

@Alek99 Alek99 commented Apr 1, 2026

Summary

  • Remove Enterprise from docs navbar
  • Rename navbar items (Start → Overview, AI Builder → Build with AI)
  • Clean up enterprise-related active state logic in secondary navbar
  • Minor doc page styling updates

Test plan

  • Verify docs navbar renders correctly without Enterprise link
  • Verify Framework tab active state works properly without enterprise exclusion
  • Check other navbar items still highlight correctly

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Alek99 Alek99 requested a review from carlosabadia April 1, 2026 02:22
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 1, 2026

Greptile Summary

This PR makes cosmetic and navigational clean-up changes to the docs site: the Enterprise entry is removed from the docs navbar (and its associated active-state logic is cleaned up in both docs_navbar.py and secondary_navbar.py), two navbar labels are renamed ("Start" → "Overview", "AI Builder" → "Build with AI"), and several minor styling updates are applied to the doc page footer, link colours, and TOC heading.

Key changes:

  • pcweb/views/docs_navbar.py / secondary_navbar.py: Enterprise nav item and path-exclusion logic removed; menu labels renamed.
  • pcweb/templates/docpage/docpage.py: Footer restructured — newsletter form and Product Hunt badge (ph_1) removed, copyright text repositioned, button pl-0 padding added, and an icon added to the "On This Page" heading. newsletter_form and ph_1 are still imported but no longer used (line 337).
  • pcweb/templates/docpage/blocks/typography.py: doclink / doclink2 link colour updated from violet-10 to slate tokens with dark-mode support.
  • assets/tailwind-theme.css: Inline code badge colours switched from violet to slate; a pre-existing commented-out padding rule remains.
  • pcweb/whitelist.py: Unintentional extra space introduced in the WHITELISTED_PAGES assignment.

Confidence Score: 5/5

Safe to merge — all remaining findings are minor style/cleanup issues with no functional impact.

All changes are cosmetic (colour tokens, label renames, layout tweaks) or clean removal of the enterprise nav entry. The only actionable finding is the two unused imports left behind in docpage.py, which is a cleanup nit with no runtime impact. All other notes are whitespace and a pre-existing commented-out CSS rule.

pcweb/templates/docpage/docpage.py — unused newsletter_form and ph_1 imports at line 337 should be removed.

Important Files Changed

Filename Overview
pcweb/views/docs_navbar.py Removes enterprise import/nav item and enterprise active-state exclusion; renames "Start" → "Overview" and "AI Builder" → "Build with AI". Clean and correct.
pcweb/views/secondary_navbar.py Mirrors docs_navbar.py by removing the enterprise active-state exclusion from the Framework menu-item logic. Straightforward and correct.
pcweb/templates/docpage/docpage.py Footer restructured (newsletter form and ph_1 removed, copyright repositioned, dark-mode toggle extracted); button padding and TOC icon tweaks — but newsletter_form and ph_1 are still imported unused at line 337.
pcweb/templates/docpage/blocks/typography.py doclink and doclink2 updated to use slate colour tokens instead of violet-10, adding dark-mode variants. Straightforward colour update.
assets/tailwind-theme.css Inline code/badge element colour tokens changed from violet to slate palette. Contains a pre-existing commented-out padding rule that should be removed.
pcweb/whitelist.py Minor unintentional double-space introduced in the WHITELISTED_PAGES assignment; functionally harmless.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Router Path] --> B{active_str starts with /}
    B -- Yes --> C[active = path == active_str\ne.g. Overview active only at /docs]
    B -- No --> D{active_str == 'framework'}
    D -- Yes --> E[is_docs = path contains /docs\nis_ai_builder = path contains ai-builder\nis_hosting = path contains hosting\nis_start = path == /docs]
    E --> F[active = is_docs AND NOT is_ai_builder\nAND NOT is_hosting AND NOT is_start]
    D -- No --> G[active = path contains active_str\ne.g. Build with AI, Cloud]
    C --> H[Highlight nav item]
    F --> H
    G --> H
Loading

Comments Outside Diff (1)

  1. pcweb/templates/docpage/docpage.py, line 337 (link)

    P2 Unused imports after footer cleanup

    newsletter_form and ph_1 are still imported on this line, but both were removed from docpage_footer in this PR (the rx.box(newsletter_form(), ...) call and the ph_1() usage were deleted). These imports are now dead code.

Reviews (1): Last reviewed commit: "doc page touch ups" | Re-trigger Greptile

Comment thread pcweb/whitelist.py Outdated
"""

WHITELISTED_PAGES = []
WHITELISTED_PAGES = []
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Extra whitespace in assignment

There are two spaces between = and [], which is inconsistent with PEP 8 style.

Suggested change
WHITELISTED_PAGES = []
WHITELISTED_PAGES = []

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread assets/tailwind-theme.css
border-color: var(--c-slate-4);
/* padding: 0rem 0.125rem 0rem 0.125rem; */
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Commented-out code should be removed

This /* padding: ... */ comment is dead code that has no effect and adds noise. Per project policy, commented-out code should be cleaned up before merging.

Suggested change

Rule Used: Remove commented-out code before merging PRs. (source)

Learnt From
reflex-dev/reflex-web#1619

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Copy link
Copy Markdown
Collaborator

@carlosabadia carlosabadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need to run ruff to pass the pre-commit

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Alek99 Alek99 merged commit 9655422 into main Apr 1, 2026
10 checks passed
@Alek99 Alek99 deleted the doc-page-touch-ups branch April 1, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants