Skip to content

add integration name#1814

Merged
Alek99 merged 2 commits intomainfrom
carlos/add-sr-integrations
Apr 8, 2026
Merged

add integration name#1814
Alek99 merged 2 commits intomainfrom
carlos/add-sr-integrations

Conversation

@carlosabadia
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR improves accessibility in the template details sidebar by adding a visually-hidden <span class="sr-only"> element containing the integration name inside the integrations_circle component. Since integration icons rely solely on a hover tooltip for labeling, screen readers may not reliably announce the integration name; the sr-only span ensures assistive technologies always have access to it.

  • Adds rx.el.span(integration_name, class_name=\"sr-only\") alongside the tooltip in integrations_circle
  • The span is placed outside the tooltip trigger div but within the outer wrapper, so it won't interfere with tooltip behaviour
  • Note: integration_name is passed to the sr-only span as-is (potentially containing underscores, e.g. \"my_integration\"), while the visual icon uses formatted_integration_name (lowercase + spaces). Consider using formatted_integration_name for a more natural screen reader experience.

Confidence Score: 5/5

Safe to merge — small, isolated accessibility improvement with no functional risk.

The only finding is a P2 style suggestion to use the pre-formatted integration name in the sr-only span for better screen reader pronunciation. This does not affect functionality, correctness, or visual output. The change is minimal and well-scoped.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
pcweb/pages/templates/template_details/views/sidebar.py Adds a sr-only span with the raw integration_name (may contain underscores) for screen reader accessibility in integrations_circle; consider using formatted_integration_name for a more natural screen-reader announcement.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["integrations_circle(integration_name)"] --> B["format name\n(lowercase, replace _ with space)"]
    B --> C["ui.tooltip\n(trigger: icon div, content: integration_name)"]
    A --> D["rx.el.span sr-only\n(integration_name) ← NEW"]
    C --> E["Visual users see icon + hover tooltip"]
    D --> F["Screen readers announce integration name"]
Loading

Reviews (1): Last reviewed commit: "add integration name" | Re-trigger Greptile

@Alek99 Alek99 self-requested a review April 8, 2026 17:25
@Alek99 Alek99 merged commit 21ef786 into main Apr 8, 2026
10 checks passed
@Alek99 Alek99 deleted the carlos/add-sr-integrations branch April 8, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants