Skip to content

Commit 1cc2431

Browse files
committed
exclude ClassVar from prop/docstring generation
ClassVar should never be accepted in a `create` function
1 parent e025f19 commit 1cc2431

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

packages/reflex-base/src/reflex_base/utils/pyi_generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from itertools import chain
2323
from pathlib import Path
2424
from types import MappingProxyType, ModuleType, SimpleNamespace, UnionType
25-
from typing import Any, get_args, get_origin
25+
from typing import Any, ClassVar, get_args, get_origin
2626

2727
from reflex_base.components.component import DEFAULT_TRIGGERS_AND_DESC, Component
2828
from reflex_base.vars.base import Var
@@ -579,7 +579,7 @@ def _extract_class_props_as_ast_nodes(
579579
or name in EXCLUDED_PROPS
580580
or name in all_props
581581
or name in event_triggers
582-
or (isinstance(value, str) and "ClassVar" in value)
582+
or get_origin(value) is ClassVar
583583
):
584584
continue
585585
all_props.add(name)

pyi_hashes.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
2-
"packages/reflex-components-code/src/reflex_components_code/code.pyi": "e052a5d7bb20a7aa02f6d9241c6265a7",
3-
"packages/reflex-components-code/src/reflex_components_code/shiki_code_block.pyi": "a6a1117b4c6519bb22f49a5823383404",
2+
"packages/reflex-components-code/src/reflex_components_code/code.pyi": "714688c5b43deb05a65ff66e042c8c09",
3+
"packages/reflex-components-code/src/reflex_components_code/shiki_code_block.pyi": "1aaa72237f8f000967a34bc3e2196b5e",
44
"packages/reflex-components-core/src/reflex_components_core/__init__.pyi": "82b29d23f2490161d42fd21021bd39c3",
55
"packages/reflex-components-core/src/reflex_components_core/base/__init__.pyi": "7009187aaaf191814d031e5462c48318",
66
"packages/reflex-components-core/src/reflex_components_core/base/app_wrap.pyi": "c0c6564e0f3f025551e02b3e9458200b",
@@ -20,7 +20,7 @@
2020
"packages/reflex-components-core/src/reflex_components_core/core/helmet.pyi": "257b7d1ff394d7dfb79fc6e9bf583463",
2121
"packages/reflex-components-core/src/reflex_components_core/core/html.pyi": "0515ecd0f7a1e6175b5781ee2a15a519",
2222
"packages/reflex-components-core/src/reflex_components_core/core/sticky.pyi": "c13b4c9ddeccc854f7d4f735b6b8bf35",
23-
"packages/reflex-components-core/src/reflex_components_core/core/upload.pyi": "09ece177609cb795be88bcda8aec65f1",
23+
"packages/reflex-components-core/src/reflex_components_core/core/upload.pyi": "f5529c6cb678c5287d5b06c7e288bce6",
2424
"packages/reflex-components-core/src/reflex_components_core/core/window_events.pyi": "ccbd7f4c55eb499a058b4822db3639a3",
2525
"packages/reflex-components-core/src/reflex_components_core/datadisplay/__init__.pyi": "c96fed4da42a13576d64f84e3c7cb25c",
2626
"packages/reflex-components-core/src/reflex_components_core/el/__init__.pyi": "f09129ddefb57ab4c7769c86dc9a3153",
@@ -98,16 +98,16 @@
9898
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/container.pyi": "422f06113f95e1f529b0c5fb063a924a",
9999
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/flex.pyi": "6974d7234d20ab3962ea3f214621f0fa",
100100
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/grid.pyi": "d3fc6e269dad51d58ef216f4f1383161",
101-
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/list.pyi": "371ec28a80a0fee23aa61cc3dd8937ca",
101+
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/list.pyi": "562a81aa0ecdb5e1df3ffeac627f1fac",
102102
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/section.pyi": "8fc9ace12dc2203ac03f4e1eb40b0524",
103103
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/spacer.pyi": "9465d40e37799336ab293bd9f573239d",
104104
"packages/reflex-components-radix/src/reflex_components_radix/themes/layout/stack.pyi": "86bd2f0438888594ed2c27f33b1de618",
105105
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/__init__.pyi": "de7ee994f66a4c1d1a6ac2ad3370c30e",
106106
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/blockquote.pyi": "cab479bcd17a1de02a160a128d6c79c8",
107-
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/code.pyi": "c0d9fbb0f60356fbeee779d1f6d7074d",
108-
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/heading.pyi": "38340f3146519a872016b3e25d6b39ef",
109-
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/link.pyi": "53afad79280af8d7dca69d75f96f0096",
110-
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/text.pyi": "fd866ed867c6420fb9e1907b36942917",
107+
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/code.pyi": "bba3d1b425aa8b6cc33a40efa0dcb771",
108+
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/heading.pyi": "db7f5d1ee9840c362088387383e2ee1b",
109+
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/link.pyi": "168df16b7901bf3618745c1e9177e354",
110+
"packages/reflex-components-radix/src/reflex_components_radix/themes/typography/text.pyi": "9bb6cc58f1ab188708e8b65189bddcaa",
111111
"packages/reflex-components-react-player/src/reflex_components_react_player/audio.pyi": "dde60f9e0b7a2427570d88ae579d984a",
112112
"packages/reflex-components-react-player/src/reflex_components_react_player/react_player.pyi": "2cd9d0cb2f6acd5bd0223fbdd74df232",
113113
"packages/reflex-components-react-player/src/reflex_components_react_player/video.pyi": "18e673fcb6ef62d17f9b06d38d713b43",

0 commit comments

Comments
 (0)