Skip to content

Commit 26d2839

Browse files
Alek99claude
andcommitted
docs: address review — palette tokens, ui.cn, color grid, uppercase headers
- Replace hardcoded #1a1b1d sidebar bg with dark:before:bg-secondary-2. - Switch _PILL_BTN_CLASS to text-sm font-medium and the secondary-* palette. - Use border-secondary-* / bg-secondary-* for the controls panel and props table header / chrome. - Merge prop-table column header classes via ui.cn(...) instead of string concatenation. - Pack the color_scheme popover into a fixed grid-cols-[repeat(6,2rem)] swatch grid so the rows align evenly; give inactive swatches a transparent border so the active selection doesn't shift the layout. - Uppercase the props table headers (prop / type / default / description). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7ff5f76 commit 26d2839

2 files changed

Lines changed: 21 additions & 17 deletions

File tree

docs/app/reflex_docs/pages/docs/component.py

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from typing import Literal, Union, _GenericAlias, get_args, get_origin
1010

1111
import reflex as rx
12+
import reflex_components_internal as ui
1213
from reflex.components.base.fragment import Fragment
1314
from reflex.components.component import Component
1415
from reflex.components.radix.primitives.base import RadixPrimitiveComponent
@@ -81,12 +82,12 @@ class PropDocsState(rx.State):
8182

8283

8384
_PILL_BTN_CLASS = (
84-
"font-small cursor-pointer rounded-md px-2.5 py-1 text-slate-11 "
85-
"border border-slate-5 bg-slate-1 hover:bg-slate-3 transition-colors"
85+
"text-sm font-medium cursor-pointer rounded-md px-2.5 py-1 text-secondary-11 "
86+
"border border-secondary-5 bg-secondary-1 hover:bg-secondary-3 transition-colors"
8687
)
8788
_PILL_BTN_ACTIVE_CLASS = (
88-
"font-small cursor-pointer rounded-md px-2.5 py-1 text-slate-12 "
89-
"border border-slate-8 bg-slate-4"
89+
"text-sm font-medium cursor-pointer rounded-md px-2.5 py-1 text-secondary-12 "
90+
"border border-secondary-8 bg-secondary-4"
9091
)
9192

9293

@@ -197,7 +198,7 @@ def render_select(prop: PropDocumentation, component: type[Component], prop_dict
197198
),
198199
),
199200
rx.popover.content(
200-
rx.grid(
201+
rx.box(
201202
*[
202203
rx.box(
203204
rx.icon(
@@ -209,16 +210,18 @@ def render_select(prop: PropDocumentation, component: type[Component], prop_dict
209210
bg=f"var(--{color}-9)",
210211
on_click=PropDocsState.setvar(f"{name}", color),
211212
border=rx.cond(
212-
var == color, "2px solid var(--gray-12)", ""
213+
var == color,
214+
"2px solid var(--gray-12)",
215+
"2px solid transparent",
213216
),
214-
class_name="relative shrink-0 rounded-md size-8 cursor-pointer",
217+
class_name="relative shrink-0 rounded-md size-8 cursor-pointer box-border",
215218
)
216219
for color in list(map(str, type_.__args__))
217220
if color != ""
218221
],
219-
columns="6",
220-
spacing="3",
222+
class_name="grid grid-cols-[repeat(6,2rem)] gap-3",
221223
),
224+
class_name="w-fit",
222225
),
223226
)
224227
literal_values = [str(a) for a in type_.__args__ if str(a) != ""]
@@ -459,7 +462,8 @@ def generate_props(
459462
)
460463

461464
table_header_class_name = (
462-
"font-small text-slate-12 text-normal w-auto justify-start pl-4 font-bold"
465+
"text-xs text-secondary-11 w-auto justify-start pl-4 font-semibold "
466+
"uppercase tracking-wider"
463467
)
464468

465469
prop_dict = {}
@@ -764,7 +768,7 @@ def _render_dynamic_prop(indent: str, p, var) -> rx.Component:
764768
)
765769
for prop, control in interactive_controls
766770
],
767-
class_name="flex flex-col gap-3 border border-slate-4 rounded-md p-4 bg-slate-2 mb-4 w-full",
771+
class_name="flex flex-col gap-3 border border-secondary-4 rounded-md p-4 bg-secondary-2 mb-4 w-full",
768772
)
769773

770774
return rx.vstack(
@@ -788,22 +792,22 @@ def _render_dynamic_prop(indent: str, p, var) -> rx.Component:
788792
rx.table.row(
789793
rx.table.column_header_cell(
790794
"prop",
791-
class_name=table_header_class_name + " w-[9rem]",
795+
class_name=ui.cn(table_header_class_name, "w-[9rem]"),
792796
),
793797
rx.table.column_header_cell(
794798
"type",
795-
class_name=table_header_class_name + " w-[34rem]",
799+
class_name=ui.cn(table_header_class_name, "w-[34rem]"),
796800
),
797801
rx.table.column_header_cell(
798802
"default",
799-
class_name=table_header_class_name + " w-[4rem]",
803+
class_name=ui.cn(table_header_class_name, "w-[4rem]"),
800804
),
801805
rx.table.column_header_cell(
802806
"description",
803-
class_name=table_header_class_name + " w-[18rem]",
807+
class_name=ui.cn(table_header_class_name, "w-[18rem]"),
804808
),
805809
),
806-
class_name="bg-slate-3",
810+
class_name="bg-secondary-3",
807811
),
808812
body,
809813
variant="surface",

docs/app/reflex_docs/templates/docpage/docpage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -792,7 +792,7 @@ def wrapper(*args, **kwargs) -> rx.Component:
792792
sidebar,
793793
class_name=(
794794
"w-[19.5rem] shrink-0 hidden lg:block z-10 border-r border-m-slate-4 dark:border-m-slate-10 sticky left-0 "
795-
"before:content-[''] before:absolute before:top-0 before:bottom-0 before:right-0 before:w-[100vw] before:bg-white-1 dark:before:bg-[#1a1b1d] before:-z-10 "
795+
"before:content-[''] before:absolute before:top-0 before:bottom-0 before:right-0 before:w-[100vw] before:bg-white-1 dark:before:bg-secondary-2 before:-z-10 "
796796
+ rx.cond(
797797
HostingBannerState.is_banner_visible,
798798
" top-[113px] h-[calc(100vh-113px)]",

0 commit comments

Comments
 (0)