do not use cwd for tests

Author: masenf

tests/units/assets/test_assets.py

@@ -6,15 +6,40 @@
 
 import reflex as rx
 import reflex.constants as constants
+from reflex.assets import remove_stale_external_asset_symlinks
 
 
-def test_shared_asset() -> None:
+@pytest.fixture
+def mock_asset_path(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
+    """Create a mock asset file and patch the current working directory.
+
+    Args:
+        tmp_path: A temporary directory provided by pytest.
+        monkeypatch: A pytest fixture for patching.
+
+    Returns:
+        The path to a tmp cwd that will be used for assets.
+    """
+    # Create a temporary directory to act as the current working directory.
+    mock_cwd = tmp_path / "mock_asset_path"
+    mock_cwd.mkdir()
+    monkeypatch.chdir(mock_cwd)
+
+    return mock_cwd
+
+
+def test_shared_asset(mock_asset_path: Path) -> None:
     """Test shared assets."""
     # The asset function copies a file to the app's external assets directory.
     asset = rx.asset(path="custom_script.js", shared=True, subfolder="subfolder")
     assert asset == "/external/test_assets/subfolder/custom_script.js"
     result_file = Path(
-        Path.cwd(), "assets/external/test_assets/subfolder/custom_script.js"
+        mock_asset_path,
+        "assets",
+        "external",
+        "test_assets",
+        "subfolder",
+        "custom_script.js",
     )
     assert result_file.exists()
 
@@ -24,17 +49,19 @@ def test_shared_asset() -> None:
     # Test the asset function without a subfolder.
     asset = rx.asset(path="custom_script.js", shared=True)
     assert asset == "/external/test_assets/custom_script.js"
-    result_file = Path(Path.cwd(), "assets/external/test_assets/custom_script.js")
+    result_file = Path(
+        mock_asset_path, "assets", "external", "test_assets", "custom_script.js"
+    )
     assert result_file.exists()
 
     # clean up
-    shutil.rmtree(Path.cwd() / "assets/external")
+    shutil.rmtree(Path(mock_asset_path) / "assets" / "external")
 
     with pytest.raises(FileNotFoundError):
         asset = rx.asset("non_existent_file.js")
 
     # Nothing is done to assets when file does not exist.
-    assert not Path(Path.cwd() / "assets/external").exists()
+    assert not Path(mock_asset_path / "assets" / "external").exists()
 
 
 @pytest.mark.parametrize(
@@ -56,13 +83,13 @@ def test_invalid_assets(path: str, shared: bool) -> None:
 
 
 @pytest.fixture
-def custom_script_in_asset_dir() -> Generator[Path, None, None]:
+def custom_script_in_asset_dir(mock_asset_path: Path) -> Generator[Path, None, None]:
     """Create a custom_script.js file in the app's assets directory.
 
     Yields:
         The path to the custom_script.js file.
     """
-    asset_dir = Path.cwd() / constants.Dirs.APP_ASSETS
+    asset_dir = mock_asset_path / constants.Dirs.APP_ASSETS
     asset_dir.mkdir(exist_ok=True)
     path = asset_dir / "custom_script.js"
     path.touch()
@@ -81,12 +108,10 @@ def test_local_asset(custom_script_in_asset_dir: Path) -> None:
     assert asset == "/custom_script.js"
 
 
-def test_remove_stale_external_asset_symlinks() -> None:
+def test_remove_stale_external_asset_symlinks(mock_asset_path: Path) -> None:
     """Test that stale symlinks and empty dirs in assets/external/ are cleaned up."""
-    from reflex.assets import remove_stale_external_asset_symlinks
-
     external_dir = (
-        Path.cwd() / constants.Dirs.APP_ASSETS / constants.Dirs.EXTERNAL_APP_ASSETS
+        mock_asset_path / constants.Dirs.APP_ASSETS / constants.Dirs.EXTERNAL_APP_ASSETS
     )
 
     # Set up: create a subdirectory with a broken symlink.
@@ -106,30 +131,23 @@ def test_remove_stale_external_asset_symlinks() -> None:
     assert valid_symlink.is_symlink()
     assert valid_symlink.resolve().exists()
 
-    try:
-        remove_stale_external_asset_symlinks()
+    remove_stale_external_asset_symlinks()
 
-        # Broken symlink and its empty parent dirs should be removed.
-        assert not stale_symlink.exists()
-        assert not stale_symlink.is_symlink()
-        assert not stale_dir.exists()
-        assert not (external_dir / "old_module").exists()
+    # Broken symlink and its empty parent dirs should be removed.
+    assert not stale_symlink.exists()
+    assert not stale_symlink.is_symlink()
+    assert not stale_dir.exists()
+    assert not (external_dir / "old_module").exists()
 
-        # Valid symlink should be preserved.
-        assert valid_symlink.is_symlink()
-        assert valid_symlink.resolve().exists()
-    finally:
-        # Clean up.
-        shutil.rmtree(external_dir)
+    # Valid symlink should be preserved.
+    assert valid_symlink.is_symlink()
+    assert valid_symlink.resolve().exists()
 
 
-def test_remove_stale_symlinks_no_external_dir(tmp_path: Path, monkeypatch) -> None:
+def test_remove_stale_symlinks_no_external_dir(mock_asset_path: Path) -> None:
     """Test that cleanup is a no-op when assets/external/ doesn't exist."""
-    from reflex.assets import remove_stale_external_asset_symlinks
-
-    monkeypatch.chdir(tmp_path)
     external_dir = (
-        tmp_path / constants.Dirs.APP_ASSETS / constants.Dirs.EXTERNAL_APP_ASSETS
+        mock_asset_path / constants.Dirs.APP_ASSETS / constants.Dirs.EXTERNAL_APP_ASSETS
     )
     assert not external_dir.exists()
     # Should not raise.