Skip to content

Commit 6bf9464

Browse files
committed
fix pyright errors surfaced by pre-commit
- `page.context.cookies()` returns Playwright's TypedDict ``Cookie`` where `name` is not required; switch to ``cookie_info.get("name", "")``. - In `test_linked_state.tab_factory`, the inner ``factory`` closure lost the ``linked_state.frontend_url is not None`` narrowing; capture the URL in a local variable before defining the closure so pyright keeps the non-None type. https://claude.ai/code/session_01B2zzr5B8FE4R5ePeQaetaZ
1 parent 988f9fb commit 6bf9464

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

tests/integration/test_client_storage.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ def cookie_info_map(page: Page) -> dict[str, dict]:
216216
A map of cookie names to cookie info.
217217
"""
218218
return {
219-
cookie_info["name"]: dict(cookie_info) for cookie_info in page.context.cookies()
219+
cookie_info.get("name", ""): dict(cookie_info)
220+
for cookie_info in page.context.cookies()
220221
}
221222

222223

tests/integration/test_linked_state.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,17 +307,18 @@ def tab_factory(
307307
"""
308308
assert linked_state.app_instance is not None, "app is not running"
309309
assert linked_state.frontend_url is not None
310+
frontend_url = linked_state.frontend_url
310311

311312
pages: list[Page] = []
312313
extra_pages: list[Page] = []
313314

314315
def factory() -> Page:
315316
if not pages:
316-
page.goto(linked_state.frontend_url)
317+
page.goto(frontend_url)
317318
pages.append(page)
318319
return page
319320
new_page = page.context.new_page()
320-
new_page.goto(linked_state.frontend_url)
321+
new_page.goto(frontend_url)
321322
pages.append(new_page)
322323
extra_pages.append(new_page)
323324
return new_page

0 commit comments

Comments
 (0)