Skip to content

Commit bbe8847

Browse files
committed
Switch to using isolated tmp dirs for test fixtures
1 parent 02650f3 commit bbe8847

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

tests/integration/tests_playwright/test_frontend_path.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,35 +52,33 @@ def bouncer():
5252

5353

5454
@pytest.fixture
55-
def onload_redirect_app(tmp_path_factory) -> Generator[AppHarness, None, None]:
55+
def onload_redirect_app(tmp_path) -> Generator[AppHarness, None, None]:
5656
"""Start the OnLoadRedirectApp without setting REFLEX_FRONTEND_PATH".
5757
5858
This is a baseline used to show on_load redirects work without a frontend_path.
5959
6060
Args:
61-
tmp_path_factory: pytest tmp_path_factory fixture
61+
tmp_path: pytest tmp_path fixture
6262
6363
Yields:
6464
running AppHarness instance
6565
"""
6666
with AppHarnessProd.create(
67-
root=tmp_path_factory.mktemp("frontend_path_app"),
67+
root=tmp_path / "onload_redirect_app",
6868
app_source=OnLoadRedirectApp,
6969
) as harness:
7070
assert harness.app_instance is not None, "app is not running"
7171
yield harness
7272

7373

7474
@pytest.fixture
75-
def onload_redirect_with_prefix_app(
76-
tmp_path_factory,
77-
) -> Generator[AppHarness, None, None]:
75+
def onload_redirect_with_prefix_app(tmp_path) -> Generator[AppHarness, None, None]:
7876
"""Start the OnLoadRedirectApp with REFLEX_FRONTEND_PATH set to "/prefix".
7977
8078
This simulates setting the REFLEX_FRONTEND_PATH to identify issues with redirection.
8179
8280
Args:
83-
tmp_path_factory: pytest tmp_path_factory fixture
81+
tmp_path: pytest tmp_path fixture
8482
8583
Yields:
8684
running AppHarness instance
@@ -89,7 +87,7 @@ def onload_redirect_with_prefix_app(
8987
try:
9088
environment.REFLEX_FRONTEND_PATH.set(prefix)
9189
with AppHarness.create(
92-
root=tmp_path_factory.mktemp("frontend_path_app"),
90+
root=tmp_path / "onload_redirect_with_prefix_app",
9391
app_source=OnLoadRedirectApp,
9492
) as harness:
9593
assert harness.app_instance is not None, "app is not running"

0 commit comments

Comments
 (0)