Close files after copying in upload_file (#5679)

maximvlah · Maxim Vlah · web-flow · commit c106be7e0935 · 2025-08-07T09:55:00.000-07:00
* fix: fix memory leak in upload_file

* fix: closing in another loop?

---------

Co-authored-by: Maxim Vlah &lt;m.vlah@senbax.de&gt;
diff --git a/reflex/app.py b/reflex/app.py
@@ -1926,6 +1926,13 @@ async def upload_file(request: Request):
                 )
             )
 
+        for file in files:
+            if not isinstance(file, StarletteUploadFile):
+                raise UploadValueError(
+                    "Uploaded file is not an UploadFile." + str(file)
+                )
+            await file.close()
+
         event = Event(
             token=token,
             name=handler,

Original file line number	Diff line number	Diff line change
`@@ -1926,6 +1926,13 @@ async def upload_file(request: Request):`
`1926`	`1926`	`)`
`1927`	`1927`	`)`
`1928`	`1928`
	`1929`	`+ for file in files:`
	`1930`	`+ if not isinstance(file, StarletteUploadFile):`
	`1931`	`+ raise UploadValueError(`
	`1932`	`+ "Uploaded file is not an UploadFile." + str(file)`
	`1933`	`+ )`
	`1934`	`+ await file.close()`
	`1935`	`+`
`1929`	`1936`	`event = Event(`
`1930`	`1937`	`token=token,`
`1931`	`1938`	`name=handler,`