fix potential issues related to sitemap generation

Author: bhatia2akshit

reflex/app.py

@@ -693,7 +693,7 @@ def add_page(
         image: str = constants.DefaultPage.IMAGE,
         on_load: EventType[()] | None = None,
         meta: list[dict[str, str]] = constants.DefaultPage.META_LIST,
-        sitemap_priority: float = None,
+        sitemap_priority: float = constants.DefaultPage.SITEMAP_PRIORITY,
         sitemap_changefreq: str = constants.DefaultPage.SITEMAP_CHANGEFREQ,
     ):
         """Add a page to the app.

reflex/constants/route.py

@@ -63,6 +63,8 @@ class DefaultPage(SimpleNamespace):
     META_LIST = []
     # The default changefrequency for sitemap generation.
     SITEMAP_CHANGEFREQ = "weekly"
+    # The default priority for sitemap generation.
+    SITEMAP_PRIORITY = 10.0
 
 
 # 404 variables

reflex/sitemap.py

@@ -89,16 +89,19 @@ def generate_links_for_sitemap(app_instance) -> List[dict[str, str]]:
         if not route.startswith("/"):
             route = f"/{route}"
 
-        # extract sitemap properties from the app's property
+        sitemap_changefreq = constants.DefaultPage.SITEMAP_CHANGEFREQ  # default value
+        sitemap_priority = constants.DefaultPage.SITEMAP_PRIORITY  # default value
+
+        # extract sitemap properties from the app's property, route exist in the compiled pages.
         if route in app_instance.site_map_properties:
             sitemap_priority = app_instance.site_map_properties[route]["priority"]
             sitemap_changefreq = app_instance.site_map_properties[route]["changefreq"]
 
-        else:
-            # calculate priority as it is none
+        if (
+            sitemap_priority == constants.DefaultPage.SITEMAP_PRIORITY
+        ):  # indicates that user didn't set priority
             depth = route.count("/")
             sitemap_priority = max(0.5, 1.0 - (depth * 0.1))
-            sitemap_changefreq = "weekly"
 
         deploy_url = get_config().deploy_url  # pick domain url from the config file.
 

tests/units/test_app.py

@@ -353,6 +353,7 @@ def test_add_duplicate_page_route_error(app, first_page, second_page, route):
 
 
 def test_add_page_with_sitemap_properties(app):
+    """Test if the sitemap properties of the app instance is set properly or not."""
     # check with given values.
     app.add_page(
         page1, route="/page1", sitemap_priority=0.9, sitemap_changefreq="daily"
@@ -361,7 +362,8 @@ def test_add_page_with_sitemap_properties(app):
 
     # check default values added.
     app.add_page(page2, route="/page2")
-    assert app.sitemap_properties["page2"] == {"priority": None, "changefreq": "weekly"}
+    print(app.sitemap_properties)
+    assert app.sitemap_properties["page2"] == {"priority": 10.0, "changefreq": "weekly"}
 
 
 def test_initialize_with_admin_dashboard(test_model):