Add sitemap generation to reflex app#3936
Conversation
4015975 to
b0cb5f3
Compare
picklelo
left a comment
There was a problem hiding this comment.
@TG199 thanks for the contribution! We currently use next-sitemap to automatically generate a sitemap when you do reflex export or reflex run --env prod
See here:
Line 38 in ef38ac2
Does that feature work for you? I think offloading the sitemap generation to a third party library as we do now is nice unless there's some functionality missing.
|
Hi @picklelo, |
This commit moves all sitemap generation functions from the separate sitemap file into app.py. Developers can now easily integrate sitemaps into their applications using the add_page method. For example: app.add_page(/about, sitemap_priority=0.8, sitemap_changefreq=monthly)
f53f039 to
993cdca
Compare
|
Hi! @benedikt-bartscher After testing locally and writing unit tests, I encountered some unrelated errors when running poetry run pytest tests/units --cov. Would you recommend that I address these issues, or is there a workaround available? |
|
Hey there! It seems we haven't given this much attention, if you can rebase it to main we can try to get it merged, for now will be putting it to draft |
|
@TG199 do you plan to continue with this PR? |
|
Oh, Thank you for following up, and I apologize for the delay in getting back to this PR. Life got in the way for a while, but I definitely plan to continue and will start making progress on it right away. I appreciate your patience! |
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
After these steps, you're ready to open a pull request.