Skip to content

feat: allow disabling auto-setters via state_auto_setters config#4480

Merged
adhami3310 merged 13 commits intoreflex-dev:mainfrom
benedikt-bartscher:disable-auto-setters
May 6, 2025
Merged

feat: allow disabling auto-setters via state_auto_setters config#4480
adhami3310 merged 13 commits intoreflex-dev:mainfrom
benedikt-bartscher:disable-auto-setters

Conversation

@benedikt-bartscher
Copy link
Copy Markdown
Contributor

Closes #4477

@benedikt-bartscher
Copy link
Copy Markdown
Contributor Author

might be better to put this in rx.Config

@benedikt-bartscher benedikt-bartscher changed the title feat: allow disabling auto-setters via REFLEX_AUTO_CREATE_SETTERS feat: allow disabling auto-setters via state_auto_setters config Dec 4, 2024
@benedikt-bartscher
Copy link
Copy Markdown
Contributor Author

might be better to put this in rx.Config

I refactored it to rx.Config, but it seems like this causes a circular import for reflex-web :/

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review December 4, 2024 23:36
@benedikt-bartscher benedikt-bartscher marked this pull request as draft December 4, 2024 23:44
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #4480 will not alter performance

Comparing benedikt-bartscher:disable-auto-setters (5a43092) with main (1f7493f)

Summary

✅ 8 untouched benchmarks

@adhami3310
Copy link
Copy Markdown
Member

adhami3310 commented Feb 3, 2025

blocked on reflex-dev/reflex-web#1205

@benedikt-bartscher
Copy link
Copy Markdown
Contributor Author

blocked on #1205

Wrong number? Does not seem related.

Thanks for rebasing!

@adhami3310
Copy link
Copy Markdown
Member

Wrong number? Does not seem related.

yea it was from reflex-web

@benedikt-bartscher
Copy link
Copy Markdown
Contributor Author

reflex-dev/reflex-web#1205

Sadly, it does not seem that this resolved the issue :/

@adhami3310 adhami3310 marked this pull request as ready for review May 6, 2025 18:13
@benedikt-bartscher
Copy link
Copy Markdown
Contributor Author

Looks good to me, thanks @adhami3310

@masenf
Copy link
Copy Markdown
Collaborator

masenf commented May 6, 2025

mentioned in docs here reflex-dev/reflex-web#1348

will also be included in the autogenerated docs for API Reference > Config

Copy link
Copy Markdown
Member

@adhami3310 adhami3310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double approv

@adhami3310 adhami3310 merged commit bbf38bb into reflex-dev:main May 6, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config option to disable reflex auto-generated setters (set_varname)

3 participants